Bug 879371
| Summary: | Upstream history test failed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Branislav Náter <bnater> | ||||
| Component: | tcsh | Assignee: | Jaromír Končický <jkoncick> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Branislav Náter <bnater> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 7.0 | CC: | ovasik | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | tcsh-6.18.00-7.fc19 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-06-13 11:38:27 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 679748 [details]
Patch
The second argument of savehist() has now different meaning(after history file locking patch). To express the same thing, it has to have HIST_MERGE value, not just 1(true).
Fixed in f19 scm-commit (http://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130325/989711.html) -> MODIFIED Fix has been verified on tcsh-6.18.01-3.el7 package. No more failing in history test. <snip> 54: hashstat skipped (commands.at:560) 55: history ok 56: hup ok </snip> This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request. |
Upstream history tests didn't pass on tcsh in RHEL-7. See details bellow. Version-Release number of selected component (if applicable): RHEL-7.0-20121107.n.1 tcsh-6.18.00-4.el7 Steps to Reproduce: run upstream tcsh test suite or our test /CoreOS/tcsh/Sanity/upstream Actual results: <snip> 55: history FAILED (commands.at:594) </snip> Expected results: <snip> 55: history ok </snip> Additional details: log from affected test: # cat testsuite.log # -*- compilation -*- 55. commands.at:563: testing history ... ./commands.at:594: tcsh -f -q -i < history.csh | sed 's/ [^ ]* / TIME /' --- - 2012-11-22 11:15:21.368464755 -0500 +++ /tmp/tmp.ufTVPzcFM7/BUILD/tcsh-6.18.00/testsuite.dir/at-groups/55/stdout 2012-11-22 11:15:21.358614484 -0500 @@ -34,16 +34,18 @@ 16 TIME history -S hist3 17 TIME set savehist= ( 5 merge ) 18 TIME history -S hist3 - 19 TIME history -M hist2 - 20 TIME echo --- - 21 TIME history + 19 TIME history -S hist3 <------ this item seems to be extra item + 20 TIME history -M hist2 + 21 TIME history -S hist2 + 22 TIME echo --- + 23 TIME history --- - 22 TIME history -L hist2 - 23 TIME history -S hist2 - 24 TIME echo --- - 25 TIME history 4 + 24 TIME history -L hist2 + 25 TIME history -S hist2 + 26 TIME echo --- + 27 TIME history 4 --- - 27 TIME echo --- - 28 TIME history + 29 TIME echo --- + 30 TIME history > exit 55. commands.at:563: 55. history (commands.at:563): FAILED (commands.at:594)