RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 879371 - Upstream history test failed
Summary: Upstream history test failed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: tcsh
Version: 7.0
Hardware: Unspecified
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Jaromír Končický
QA Contact: Branislav Náter
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-22 17:30 UTC by Branislav Náter
Modified: 2014-07-01 22:55 UTC (History)
1 user (show)

Fixed In Version: tcsh-6.18.00-7.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 11:38:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch (370 bytes, patch)
2013-01-16 18:52 UTC, Roman Kollár
no flags Details | Diff

Description Branislav Náter 2012-11-22 17:30:24 UTC
Upstream history tests didn't pass on tcsh in RHEL-7. See details bellow.

Version-Release number of selected component (if applicable):
RHEL-7.0-20121107.n.1
tcsh-6.18.00-4.el7

Steps to Reproduce: 
run upstream tcsh test suite or our test /CoreOS/tcsh/Sanity/upstream

Actual results: 
<snip>
55: history                                         FAILED (commands.at:594)
</snip>

Expected results:
<snip>
55: history                                         ok
</snip>

Additional details:
log from affected test:

# cat testsuite.log 
#                             -*- compilation -*-
55. commands.at:563: testing history ...
./commands.at:594: tcsh -f -q -i < history.csh 	  | sed 's/	[^	]*	/ TIME /'
--- -	2012-11-22 11:15:21.368464755 -0500
+++ /tmp/tmp.ufTVPzcFM7/BUILD/tcsh-6.18.00/testsuite.dir/at-groups/55/stdout	2012-11-22 11:15:21.358614484 -0500
@@ -34,16 +34,18 @@
     16 TIME history -S hist3
     17 TIME set savehist= ( 5 merge )
     18 TIME history -S hist3
-    19 TIME history -M hist2
-    20 TIME echo ---
-    21 TIME history
+    19 TIME history -S hist3  <------ this item seems to be extra item
+    20 TIME history -M hist2
+    21 TIME history -S hist2
+    22 TIME echo ---
+    23 TIME history
 ---
-    22 TIME history -L hist2
-    23 TIME history -S hist2
-    24 TIME echo ---
-    25 TIME history 4
+    24 TIME history -L hist2
+    25 TIME history -S hist2
+    26 TIME echo ---
+    27 TIME history 4
 ---
-    27 TIME echo ---
-    28 TIME history
+    29 TIME echo ---
+    30 TIME history
 > exit
 
55. commands.at:563: 55. history (commands.at:563): FAILED (commands.at:594)

Comment 2 Roman Kollár 2013-01-16 18:52:33 UTC
Created attachment 679748 [details]
Patch

The second argument of savehist() has now different meaning(after history file locking patch). To express the same thing, it has to have HIST_MERGE value, not just 1(true).

Comment 3 Fridolín Pokorný 2013-03-28 13:23:57 UTC
Fixed in f19 scm-commit (http://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130325/989711.html) -> MODIFIED

Comment 5 Branislav Náter 2013-11-01 10:58:21 UTC
Fix has been verified on tcsh-6.18.01-3.el7 package. No more failing in history test.

<snip>
 54: hashstat                                        skipped (commands.at:560)
 55: history                                         ok
 56: hup                                             ok
</snip>

Comment 6 Ludek Smid 2014-06-13 11:38:27 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.