Bug 879928 (rigsofrods)
| Summary: | Review Request: rigsofrods - Vehicle simulator based on soft-body physics | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Alexeev <pahan> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, i, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-28 00:48:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 805246, 873353, 879931, 879932, 879933, 880364, 1215414, 1296489 | ||
| Bug Blocks: | |||
|
Description
Pavel Alexeev
2012-11-25 15:22:37 UTC
I think now, after resolve all listed dependencies its will be ready to review. Christopher do you plan move forward? Christopher ping? I felt so sorry on this ticket, as I couldn't find any spare time of doing the review thoroughly. I've set back to empty status. Upstream informed about incorrect fsf address: https://github.com/RigsOfRods/rigs-of-rods/issues/538 hubbitus's scratch build of rigsofrods-0.4.6.0-0.4.git.23c619a.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12586298 hubbitus's scratch build of rigsofrods-0.4.6.0-0.4.git.23c619a.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12586406 hubbitus's scratch build of rigsofrods-0.4.6.0-0.4.git.23c619a.fc23.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12586642 hubbitus's scratch build of rigsofrods-0.4.6.0-0.4.git.23c619a.fc23.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12586904 hubbitus's scratch build of rigsofrods-0.4.6.0-0.5.git.23c619a.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12587732 Major upgrade. Now does not require angelscript and caelum as it is optional deps. So, review may be continued. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/a00fa80810f3640dfadc56231e2e416ceafcb251 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/a00fa80810f3640dfadc56231e2e416ceafcb251/SPECS/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora23/rigsofrods/rigsofrods-0.4.6.0-0.5.git.23c619a.fc23.src.rpm hubbitus's scratch build of rigsofrods-0.4.6.0-0.6.git.3e56c07.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667538 Resolved issue compile on ARM: Changes: https://github.com/Hubbitus/Fedora-packaging/commit/eaa5ed7e53a9df4c78c931ba92e82b3f9e2d2471 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/eaa5ed7e53a9df4c78c931ba92e82b3f9e2d2471/SPECS/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora23/rigsofrods/rigsofrods-0.4.6.0-0.6.git.3e56c07.fc23.src.rpm Update Changelog: https://github.com/Hubbitus/Fedora-packaging/commit/1dfcc1d5a1e75e9894f9b6eeee2a95e3f1331b90 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/1dfcc1d5a1e75e9894f9b6eeee2a95e3f1331b90/SPECS/rigsofrods.spec Rrpm: http://rpm.hubbitus.info/Fedora24/rigsofrods/rigsofrods-0.4.6.0-0.7.git.64ad6f6.fc24.src.rpm Version 0.4.7.0 Changes: https://github.com/Hubbitus/rpm-rigsofrods/commit/96c4a6b1a5eafd5eaddd94e995b4171cab446a74 Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=17522362 Spec: https://raw.githubusercontent.com/Hubbitus/rpm-rigsofrods/96c4a6b1a5eafd5eaddd94e995b4171cab446a74/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora25/rigsofrods/rigsofrods-0.4.7.0-1.fc25.src.rpm Hello, - Use this simplified Source: Source0: https://github.com/RigsOfRods/rigs-of-rods/archive/%{version}/%{name}-%{version}.tar.gz - COPYING should not be listed in %doc, but in %licensi: %files %doc AUTHORS.md BUILDING.md CONTRIBUTING.md DEPENDENCIES.md README.md %license COPYING - There are several files with license other than GPLv3: *No copyright* BSL ------------------ rigs-of-rods-0.4.7.0/source/main/utils/utf8/README.md *No copyright* CC by (v2.5) --------------------------- rigs-of-rods-0.4.7.0/bin/resources/famicons/readme.txt Please add them to the License: field and add a comment explaining which license cover which parts. - You should split the data in /usr/share in a -data noarch subpackage: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 138373120 bytes in /usr/share rigsofrods-0.4.7.0-1.fc28.x86_64.rpm:138373120 See: - Several files have an incorrect FSF address in the header. You should patch them with the updated address and notify upstream about it: rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/CfgFileManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/CfgFileManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/DecalsManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/DecalsManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Enums.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Enums.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/FFT.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/FFT.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GPUNormalMapManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GPUNormalMapManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GodRaysManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GodRaysManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Help.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Help.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Hydrax.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Hydrax.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Image.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Image.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/MaterialManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/MaterialManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Mesh.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Mesh.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Module.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Module.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Noise.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Noise.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Perlin.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Perlin.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Prerequisites.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/PressurePoint.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/PressurePoint.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/ProjectedGrid.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/ProjectedGrid.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RadialGrid.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RadialGrid.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Real.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Real.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RttManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RttManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/SimpleGrid.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/SimpleGrid.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/TextureManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/TextureManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Wave.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Wave.h Hello Robert-André Mauchin. Thank you for the taking care on it. > - Use this simplified Source: > Source0: https://github.com/RigsOfRods/rigs-of-rods/archive/%{version}/%{name}-%{version}.tar.gz Done > - COPYING should not be listed in %doc, but in %licensi: > %files > %doc AUTHORS.md BUILDING.md CONTRIBUTING.md DEPENDENCIES.md README.md > %license COPYING Done > - There are several files with license other than GPLv3: > *No copyright* BSL > ------------------ > rigs-of-rods-0.4.7.0/source/main/utils/utf8/README.md > *No copyright* CC by (v2.5) > --------------------------- > rigs-of-rods-0.4.7.0/bin/resources/famicons/readme.txt > Please add them to the License: field and add a comment explaining which license cover which parts. Done > - You should split the data in /usr/share in a -data noarch subpackage: > Large data in /usr/share should live in a noarch subpackage if package is arched. > Note: Arch-ed rpms have a total of 138373120 bytes in /usr/share > rigsofrods-0.4.7.0-1.fc28.x86_64.rpm:138373120 Done > - Several files have an incorrect FSF address in the header. You should patch them with the updated address and notify upstream about it: Upstream informed about that long time ago - https://github.com/RigsOfRods/rigs-of-rods/issues/538 and it noted in changelog. If you do not insist - I do not willing patch that separately from upstream. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22792831 Changes: https://github.com/Hubbitus/rpm-rigsofrods/commit/f15a8cffc68d8275a4df81b739f8eb9a2422bc6f Spec: https://raw.githubusercontent.com/Hubbitus/rpm-rigsofrods/f15a8cffc68d8275a4df81b739f8eb9a2422bc6f/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora26/rigsofrods/rigsofrods-0.4.7.0-2.fc28.src.rpm - This part should be in %build, not %prep: # Additional flag: http://www.ogre3d.org/forums/viewtopic.php?f=2&t=71037 export CXXFLAGS="$RPM_OPT_FLAGS -lboost_system" cmake \ - rigsofrods-debuginfo.x86_64: W: invalid-license GPLv3 + CC-BY License should be separated by "and", not +. Ok. Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22823765 Changes: https://github.com/Hubbitus/rpm-rigsofrods/commit/f8689f40225ed796b3e24a2d9022b851a4f05fe5 Spec: https://raw.githubusercontent.com/Hubbitus/rpm-rigsofrods/f8689f40225ed796b3e24a2d9022b851a4f05fe5/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora26/rigsofrods/rigsofrods-0.4.7.0-3.fc28.src.rpm My message was maybe not clear, but the cmake part should be in %build too: %build # Additional flag: http://www.ogre3d.org/forums/viewtopic.php?f=2&t=71037 export CXXFLAGS="$RPM_OPT_FLAGS -lboost_system" cmake \ -DROR_USE_MYGUI="TRUE" \ -DROR_USE_OPENAL="TRUE" \ -DROR_USE_PAGED="TRUE" \ -DROR_USE_CAELUM="TRUE" \ -DROR_USE_ANGELSCRIPT="FALSE" \ -DROR_USE_SOCKETW="TRUE" \ -DSOCKETW_INCLUDE_DIRS:PATH="%{_includedir}/SocketW" \ -DPAGED_INCLUDE_DIRS:PATH="%{_includedir}/OGRE" \ -MYGUI_INCLUDE_DIRS:PATH="%{_includedir}/OGRE/Overlay" \ -DPAGED_LIBRARY_DIRS:PATH="%{_libdir}/OGRE" \ -DPAGED_LIBRARIES=%{_libdir}/OGRE/libPagedGeometry.so \ -DCAELUM_LIBRARIES=%{_libdir}/OGRE/libCaelum.so \ -DCMAKE_BUILD_TYPE=Debug \ -DCMAKE_INSTALL_PREFIX=%{buildroot}%{_prefix} \ \ . make %{?_smp_mflags} I think it just useless now. See https://github.com/RigsOfRods/rigs-of-rods/commit/17ab75843545407433dc319e1aaa6831eb854b87 Dropped. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22849976 Changes: https://github.com/Hubbitus/rpm-rigsofrods/commit/c1504cccefb9f0d1e65a2725db9427091370996d Spec: https://raw.githubusercontent.com/Hubbitus/rpm-rigsofrods/c1504cccefb9f0d1e65a2725db9427091370996d/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora26/rigsofrods/rigsofrods-0.4.7.0-4.fc28.src.rpm *** the cmake part should be in %build too ***
%build
cmake \
-DROR_USE_MYGUI="TRUE" \
-DROR_USE_OPENAL="TRUE" \
-DROR_USE_PAGED="TRUE" \
-DROR_USE_CAELUM="TRUE" \
-DROR_USE_ANGELSCRIPT="FALSE" \
-DROR_USE_SOCKETW="TRUE" \
-DSOCKETW_INCLUDE_DIRS:PATH="%{_includedir}/SocketW" \
-DPAGED_INCLUDE_DIRS:PATH="%{_includedir}/OGRE" \
-MYGUI_INCLUDE_DIRS:PATH="%{_includedir}/OGRE/Overlay" \
-DPAGED_LIBRARY_DIRS:PATH="%{_libdir}/OGRE" \
-DPAGED_LIBRARIES=%{_libdir}/OGRE/libPagedGeometry.so \
-DCAELUM_LIBRARIES=%{_libdir}/OGRE/libCaelum.so \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_INSTALL_PREFIX=%{buildroot}%{_prefix} \
\
.
make %{?_smp_mflags}
Ok. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22870369 Changes: https://github.com/Hubbitus/rpm-rigsofrods/commit/c7452f8d96077fb72ab1292a33a23d6cc98f2ba2 Spec: https://raw.githubusercontent.com/Hubbitus/rpm-rigsofrods/c7452f8d96077fb72ab1292a33a23d6cc98f2ba2/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora26/rigsofrods/rigsofrods-0.4.7.0-5.fc28.src.rpm All ok then, package accepted. Robert-André Mauchin thank you very much for the review. Do you want I review something from your packages? New repository https://pagure.io/releng/fedora-scm-requests/issue/2670 and branch https://pagure.io/releng/fedora-scm-requests/issue/2671 requested. (In reply to Pavel Alexeev from comment #25) > Robert-André Mauchin thank you very much for the review. Do you want I > review something from your packages? > > > New repository https://pagure.io/releng/fedora-scm-requests/issue/2670 and > branch https://pagure.io/releng/fedora-scm-requests/issue/2671 requested. Your forgot to request F27 branch ;) (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rigsofrods Thanks Gwyn Ciesla and Igor Gnatenko 27 requested too https://pagure.io/releng/fedora-scm-requests/issue/2694 rigsofrods-0.4.7.0-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-88134e0452 rigsofrods-0.4.7.0-5.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-88134e0452 rigsofrods-0.4.7.0-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e66322c282 rigsofrods-0.4.7.0-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. rigsofrods-0.4.7.0-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |