Bug 880880 (php-scssphp)
| Summary: | Review Request: php-scssphp - A compiler for SCSS written in PHP | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora, notting, package-review | ||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-03-29 01:24:14 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Shawn Iwinski
2012-11-28 02:25:41 UTC
Created attachment 661594 [details]
php-scssphp-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 880880
MUST:
- Please clarify License (with upstream).
Only MIT file is provided, GPLv3 only list in composer.json file...
I also think it will be great to have License header in each file.
- no need to requires php-common
only need extensions, php-common is only required for version checking
- fix the shebang
Currently, in requires: /usr/bin/env
#!/usr/bin/env php => #!/usr/bin/php
This will fix the missing dependency on php-cli.
SHOULD:
- Like for a previous review, could probably be simpler to include %{libname}/scss.inc.php (without %{_datadir}/php) and override include_path for phpunit.
(In reply to comment #2) > MUST: > > - Please clarify License (with upstream). > > Only MIT file is provided, GPLv3 only list in composer.json file... > > I also think it will be great to have License header in each file. Awaiting https://github.com/leafo/scssphp/issues/31 This latest upstream snapshot should fix all blockers. SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-scssphp.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-scssphp-0.0.4-2.20130301git3463d7d.fc18.src.rpm About removing php-common in my previous comment.
From Guidelines, you must requires all need extensions (so not the package which provides an extension). php-common is only used for version check.
In your previous spec, requiring php-common without any version have no sense, the reason why I ask to remove it.
As in this new spec, you require a minimal version, you have to do the check on php-common (or better, on php(language) which is now available on EL-6)
As the shebang is now correct, the package have a auto detected dep on /usr/bin/php, so you don't need to require php-cli.
About %{__php}, this macro is only defined:
- on Fedora
- with php-devel installed
Spec changes: https://github.com/siwinski/rpms/commit/86c2c1044fbef3ffa5be8867aea665de5e8cc83d SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-scssphp.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-scssphp-0.0.5-1.fc18.src.rpm [x] Requires php(language) : Ok.
[x] shebang : ok
[x] %{__php} macro usage : ok
No blocker
== APPROVED ==
THANKS for the review! New Package SCM Request ======================= Package Name: php-scssphp Short Description: A compiler for SCSS written in PHP Owners: siwinski Branches: f18 f19 el6 InitialCC: Git done (by process-git-requests). php-scssphp-0.0.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-scssphp-0.0.5-1.el6 php-scssphp-0.0.5-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-scssphp-0.0.5-1.fc18 php-scssphp-0.0.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository. php-scssphp-0.0.5-1.fc18 has been pushed to the Fedora 18 stable repository. php-scssphp-0.0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |