Bug 880880 (php-scssphp) - Review Request: php-scssphp - A compiler for SCSS written in PHP
Summary: Review Request: php-scssphp - A compiler for SCSS written in PHP
Keywords:
Status: CLOSED ERRATA
Alias: php-scssphp
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-28 02:25 UTC by Shawn Iwinski
Modified: 2013-04-03 02:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-29 01:24:14 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
php-scssphp-review.txt (8.75 KB, text/plain)
2012-12-11 18:41 UTC, Remi Collet
fedora: review?
Details

Description Shawn Iwinski 2012-11-28 02:25:41 UTC
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-scssphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-scssphp-0.0.4-1.fc17.src.rpm

Description:
SCSS (http://sass-lang.com/) is a CSS preprocessor that adds many features like
variables, mixins, imports, color manipulation, functions, and tons of other
powerful features.

The entire compiler comes in a single class file ready for including in any kind
of project in addition to a command line tool for running the compiler from the
terminal.

scssphp implements SCSS (3.1.20). It does not implement the SASS syntax, only
the SCSS syntax.


Fedora Account System Username: siwinski

Comment 1 Remi Collet 2012-12-11 18:41:29 UTC
Created attachment 661594 [details]
php-scssphp-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 880880

Comment 2 Remi Collet 2012-12-11 18:49:43 UTC
MUST:

- Please clarify License (with upstream).

Only MIT file is provided, GPLv3 only list in composer.json file...

I also think it will be great to have License header in each file.

- no need to requires php-common

only need extensions, php-common is only required for version checking

- fix the shebang

Currently, in requires: /usr/bin/env

#!/usr/bin/env php => #!/usr/bin/php

This will fix the missing dependency on php-cli.

SHOULD:

- Like for a previous review, could probably be simpler to include %{libname}/scss.inc.php (without %{_datadir}/php) and override include_path for phpunit.

Comment 3 Shawn Iwinski 2012-12-19 02:22:18 UTC
(In reply to comment #2)
> MUST:
> 
> - Please clarify License (with upstream).
> 
> Only MIT file is provided, GPLv3 only list in composer.json file...
> 
> I also think it will be great to have License header in each file.

Awaiting https://github.com/leafo/scssphp/issues/31

Comment 4 Shawn Iwinski 2013-03-09 19:34:40 UTC
This latest upstream snapshot should fix all blockers.


SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-scssphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-scssphp-0.0.4-2.20130301git3463d7d.fc18.src.rpm

Comment 5 Remi Collet 2013-03-10 07:47:07 UTC
About removing php-common in my previous comment.

From Guidelines, you must requires all need extensions (so not the package which provides an extension). php-common is only used for version check.

In your previous spec, requiring php-common without any version have no sense, the reason why I ask to remove it.

As in this new spec, you require a minimal version, you have to do the check on php-common (or better, on php(language) which is now available on EL-6)

As the shebang is now correct, the package have a auto detected dep on /usr/bin/php, so you don't need to require php-cli.

About %{__php}, this macro is only defined:
- on Fedora
- with php-devel installed

Comment 7 Remi Collet 2013-03-18 14:33:04 UTC
[x] Requires php(language) : Ok.
[x] shebang : ok
[x] %{__php} macro usage : ok


No blocker


== APPROVED ==

Comment 8 Shawn Iwinski 2013-03-18 15:18:19 UTC
THANKS for the review!


New Package SCM Request
=======================
Package Name: php-scssphp
Short Description: A compiler for SCSS written in PHP
Owners: siwinski
Branches: f18 f19 el6
InitialCC:

Comment 9 Gwyn Ciesla 2013-03-18 15:23:17 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2013-03-18 18:45:27 UTC
php-scssphp-0.0.5-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-scssphp-0.0.5-1.el6

Comment 11 Fedora Update System 2013-03-18 18:45:46 UTC
php-scssphp-0.0.5-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-scssphp-0.0.5-1.fc18

Comment 12 Fedora Update System 2013-03-18 22:30:20 UTC
php-scssphp-0.0.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 13 Fedora Update System 2013-03-29 01:24:16 UTC
php-scssphp-0.0.5-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 14 Fedora Update System 2013-04-03 02:02:29 UTC
php-scssphp-0.0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.