Bug 881086
| Summary: | Review Request: rubygem-audited-activerecord - Log all changes to your ActiveRecord models | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dsd, msuchy, notting, package-review |
| Target Milestone: | --- | Flags: | msuchy:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-11-30 16:49:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 881016 | ||
| Bug Blocks: | |||
|
Description
Vít Ondruch
2012-11-28 15:43:19 UTC
I would suggest to add to the end of %install:
rm -rf %{buildroot}%{gem_instdir}/.yardoc
so rpmbuild --rebuild will pass on systems where rubygem-yard is installed. But
it is not crucial since in koji it is not installed.
I prefer to move
mkdir -p .%{gem_dir}
gem install --local --install-dir .%{gem_dir} \
--force %{SOURCE0}
from %prep to %build
But all this is minor and does not block review.
Everything else is perfect.
APPROVED
Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-audited-activerecord Short Description: Log all changes to your ActiveRecord models Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). Thanks for the package and review! I use acts_as_audited in a Fedora-hosted webapp, and looks like I need to move to audited for F18 + Rails-3.1, so this package is much appreciated. Good timing too. Please can it be built in F18 too? Right now it is only in rawhide. Package Change Request ====================== Package Name: rubygem-audited-activerecord New Branches: f18 Owners: vondruch Git done (by process-git-requests). rubygem-audited-activerecord-3.0.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-audited-activerecord-3.0.0-1.fc18 rubygem-audited-activerecord-3.0.0-1.fc18 has been pushed to the Fedora 18 stable repository. |