Bug 881086 - Review Request: rubygem-audited-activerecord - Log all changes to your ActiveRecord models
Summary: Review Request: rubygem-audited-activerecord - Log all changes to your Active...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 881016
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-28 15:43 UTC by Vít Ondruch
Modified: 2013-01-11 23:59 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-11-30 16:49:50 UTC
Type: ---
Embargoed:
msuchy: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Vít Ondruch 2012-11-28 15:43:19 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-audited-activerecord.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-audited-activerecord-3.0.0-1.fc19.src.rpm
Description: Log all changes to your ActiveRecord models
Fedora Account System Username: vondruch

Comment 1 Miroslav Suchý 2012-11-28 19:07:46 UTC
I would suggest to add to the end of %install:
rm -rf %{buildroot}%{gem_instdir}/.yardoc
so rpmbuild --rebuild will pass on systems where rubygem-yard is installed. But
it is not crucial since in koji it is not installed.

I prefer to move
mkdir -p .%{gem_dir}
gem install --local --install-dir .%{gem_dir} \
            --force %{SOURCE0}
from %prep to %build

But all this is minor and does not block review.
Everything else is perfect.

APPROVED

Comment 2 Vít Ondruch 2012-11-30 14:57:04 UTC
Thank you for your review!



New Package SCM Request
=======================
Package Name: rubygem-audited-activerecord
Short Description: Log all changes to your ActiveRecord models
Owners: vondruch
Branches: 
InitialCC:

Comment 3 Gwyn Ciesla 2012-11-30 15:40:16 UTC
Git done (by process-git-requests).

Comment 4 Daniel Drake 2012-12-01 17:26:51 UTC
Thanks for the package and review!

I use acts_as_audited in a Fedora-hosted webapp, and looks like I need to move to audited for F18 + Rails-3.1, so this package is much appreciated. Good timing too.

Please can it be built in F18 too? Right now it is only in rawhide.

Comment 5 Vít Ondruch 2012-12-03 09:53:09 UTC
Package Change Request
======================
Package Name: rubygem-audited-activerecord
New Branches: f18
Owners: vondruch

Comment 6 Gwyn Ciesla 2012-12-03 12:59:57 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2012-12-04 08:11:44 UTC
rubygem-audited-activerecord-3.0.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-audited-activerecord-3.0.0-1.fc18

Comment 8 Fedora Update System 2013-01-11 23:59:46 UTC
rubygem-audited-activerecord-3.0.0-1.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.