Bug 881352
| Summary: | missing icons in high-contrast mode | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | pi_raph |
| Component: | lightdm-gtk | Assignee: | Rex Dieter <rdieter> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 44 | CC: | awilliam, christoph.wickert, dan.mashal, gregor, ikisham, rdieter |
| Target Milestone: | --- | Keywords: | Reopened, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-11 05:56:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
pi_raph
2012-11-28 18:45:55 UTC
that should have been "top right" not "bottom right" The bug here is due to two things:
- The Xfce spin doesn't come with gnome-themes-standard which provides the HighContrast GTK and icon themes.
- lightdm-gtk-greeter wants to use the HighContrastInverse themes which aren't available in Fedora 18:
lightdm-gtk-greeter-1.3.1/src/lightdm-gtk-greeter.c (lines 595-596)
g_object_set (gtk_settings_get_default (), "gtk-theme-name", "HighContrastInverse", NULL);
g_object_set (gtk_settings_get_default (), "gtk-icon-theme-name", "HighContrastInverse", NULL);
So it fails to set both the GTK and icon themes for the 'High contrast' option.
So, sounds like one plan forward would be to patch lightdm-gtk-greeter.c to use HighContrast instead, and add Requires: gnome-themes-standard any comment/objection to that? sounds reasonable, HighContrastInverse has been dropped with commit 100cbbc74a0a812b103a823dc510833a7ce6b9d8 Or we could also use another inverse theme. in a perfect world, the gtk/icon theme to be used here would be configurable, but meh. HighContrast it is. %changelog * Fri Dec 07 2012 Rex Dieter <rdieter> 1.3.1-3 - missing icons in high-contrast mode (#881352) lightdm-gtk-1.3.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lightdm-gtk-1.3.1-3.fc18 Package lightdm-gtk-1.3.1-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lightdm-gtk-1.3.1-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-19974/lightdm-gtk-1.3.1-3.fc18 then log in and leave karma (feedback). lightdm-gtk-1.3.1-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. Re-opening, because this is now broken again, because gnome-themes-extra (which contained the GTK 3 HighContrast icon theme that lightdm-gtk uses) has been retired. I am going to have to drop the dependency from the lightdm-gtk package to make it installable again. To fix this, gnome-themes-extra needs to be brought back, or just the HighContrast theme could be pulled out and shipped in another package or in lightdm-gtk , or some other high contrast icon theme that is still maintained could be used instead (I'm not aware of any, though). |