Bug 881352 - missing icons in high-contrast mode
Summary: missing icons in high-contrast mode
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: lightdm-gtk
Version: 44
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-28 18:45 UTC by pi_raph
Modified: 2025-10-10 16:23 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-12-11 05:56:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description pi_raph 2012-11-28 18:45:55 UTC
Description of problem:
When switching to high contrast mode in lightdm the two
icons on the bottom right are replaced with "red X" error icons


Version-Release number of selected component (if applicable):
Fedora-18-Beta-i686-Live-XFCE.iso
lightdm 1.4.0 Release 2.fc18

How reproducible:
Always


Steps to Reproduce:
1. boot Fedora-18-Beta-i686-Live-XFCE.iso live usbstick
2. switch to high contrast icons
  
Actual results:
fallback "red X" icons are shown

Expected results:
high contrast or regular versions of the icons should be shown


Additional info:

Comment 1 pi_raph 2012-11-29 13:10:06 UTC
that should have been "top right" not "bottom right"

Comment 2 Sergio 2012-12-07 17:58:37 UTC
The bug here is due to two things:

- The Xfce spin doesn't come with gnome-themes-standard which provides the HighContrast GTK and icon themes.

- lightdm-gtk-greeter wants to use the HighContrastInverse themes which aren't available in Fedora 18:

lightdm-gtk-greeter-1.3.1/src/lightdm-gtk-greeter.c (lines 595-596)

        g_object_set (gtk_settings_get_default (), "gtk-theme-name", "HighContrastInverse", NULL);
        g_object_set (gtk_settings_get_default (), "gtk-icon-theme-name", "HighContrastInverse", NULL);


So it fails to set both the GTK and icon themes for the 'High contrast' option.

Comment 3 Rex Dieter 2012-12-07 18:03:22 UTC
So, sounds like one plan forward would be to patch lightdm-gtk-greeter.c to use HighContrast instead, and add
Requires: gnome-themes-standard

any comment/objection to that?

Comment 4 Gregor Tätzner 2012-12-07 18:49:35 UTC
sounds reasonable, HighContrastInverse has been dropped with commit 100cbbc74a0a812b103a823dc510833a7ce6b9d8

Or we could also use another inverse theme.

Comment 5 Rex Dieter 2012-12-07 20:23:59 UTC
in a perfect world, the gtk/icon theme to be used here would be configurable, but meh.  HighContrast it is.

%changelog
* Fri Dec 07 2012 Rex Dieter <rdieter> 1.3.1-3
- missing icons in high-contrast mode (#881352)

Comment 6 Fedora Update System 2012-12-07 21:38:24 UTC
lightdm-gtk-1.3.1-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/lightdm-gtk-1.3.1-3.fc18

Comment 7 Fedora Update System 2012-12-08 22:11:56 UTC
Package lightdm-gtk-1.3.1-3.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing lightdm-gtk-1.3.1-3.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-19974/lightdm-gtk-1.3.1-3.fc18
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2012-12-11 05:56:10 UTC
lightdm-gtk-1.3.1-3.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Adam Williamson 2025-10-10 16:23:55 UTC
Re-opening, because this is now broken again, because gnome-themes-extra (which contained the GTK 3 HighContrast icon theme that lightdm-gtk uses) has been retired. I am going to have to drop the dependency from the lightdm-gtk package to make it installable again.

To fix this, gnome-themes-extra needs to be brought back, or just the HighContrast theme could be pulled out and shipped in another package or in lightdm-gtk , or some other high contrast icon theme that is still maintained could be used instead (I'm not aware of any, though).


Note You need to log in before you can comment on or make changes to this bug.