Bug 882339

Summary:	spice-xpi doesn't clean up /tmp/spicec-XXXXXX/spice-foreign socket and /tmp/spicec-XXXXXX directory after the client exits
Product:	Red Hat Enterprise Linux 6	Reporter:	David Jaša <djasa>
Component:	spice-xpi	Assignee:	Peter Hatina <phatina>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.4	CC:	acathrow, cfergeau, dblechte, lnovich, pvine, tjamrisk, tsmetana, uril
Target Milestone:	beta
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spice-xpi-2.7-23.el6	Doc Type:	Bug Fix
Doc Text:	Cause: The spice-xpi browser plugin was not cleaning up some socket files after client exit Consequence: /tmp/spicec-XXXXXX/spice-foreign socket and /tmp/spicec-XXXXXX directory are still present after the client exits. Fix: Remove these files when the clients exits Result: These 2 files no longer stay around	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-21 21:40:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	947781

Description David Jaša 2012-11-30 17:36:57 UTC

Description of problem:
spice-xpi doesn't clean up /tmp/spicec-XXXXXX/spice-foreign socket and /tmp/spicec-XXXXXX directory after the client exits.

spice-xpi creates /tmp/spicec-XXXXXX directory with two sockets before it launches the client: spice-xpi and spice-foreign, but it doesn't clean them up after client exit.

The file and directory can be left unremoved even when this bug is fixed in cases when plugin exits before the client but these cases should be much rarer than current leaving of every file.

Version-Release number of selected component (if applicable):
spice-xpi-2.7-22.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1. close all clients launched by browser plugin
2. remove all /tmp/spicec-XXXXXX directories
3. launch a client from portal, close the client again
  
Actual results:
/tmp/spicec-XXXXXX/spice-foreign directory and socket are left behind

Expected results:
no /tmp/spicec-XXXXXX directory exists anymore

Additional info:

Comment 1 Christophe Fergeau 2013-05-21 09:21:09 UTC

A patch for this issue was sent to the spice-devel mailing list:
http://lists.freedesktop.org/archives/spice-devel/2013-April/012995.html

Comment 3 Peter Hatina 2013-06-17 13:31:14 UTC

Please, check this scratch build.

https://brewweb.devel.redhat.com/taskinfo?taskID=5910797

Comment 4 Tomas Jamrisko 2013-06-18 10:29:15 UTC

Seems to work with the build from Comment 3.

Comment 5 Peter Hatina 2013-06-18 10:41:21 UTC

OK, fixed.

Comment 6 Christophe Fergeau 2013-06-19 11:56:45 UTC

Does this issue happen upstream as well? If it does, this needs to get fixed there as well if we don't want to introduce a regression if we rebase or in rhel7

Comment 13 errata-xmlrpc 2013-11-21 21:40:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2013-1667.html