Bug 884604

Summary:	Review Request: rubygem-riot - An extremely fast, expressive, and context-driven unit-testing framework
Product:	[Fedora] Fedora	Reporter:	Josef Stribny <jstribny>
Component:	Package Review	Assignee:	Bohuslav "Slavek" Kabrda <bkabrda>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bkabrda, hhorak, notting, package-review
Target Milestone:	---	Flags:	bkabrda: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-02 09:56:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	884677

Description Josef Stribny 2012-12-06 11:42:05 UTC

Spec URL: http://data-strzibny.rhcloud.com/rubygem-riot.spec
SRPM URL: http://data-strzibny.rhcloud.com/rubygem-riot-0.12.5-1.fc19.src.rpm
Description: An extremely fast, expressive, and context-driven unit-testing framework. A replacement for all other testing frameworks. Protest the slow test.
Fedora Account System Username: jstribny
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4762910

Comment 1 Bohuslav "Slavek" Kabrda 2012-12-07 12:28:18 UTC

I'll take this for a review.

Comment 2 Bohuslav "Slavek" Kabrda 2012-12-07 13:12:56 UTC

- %{gem_instdir}/MIT-LICENSE should be marked as %doc
- It is customary to keep %{gem_instdir}/%{gem_name}.gemspec in the -doc subpackage, but not mandatory, so this is not a blocker.
- You can avoid the for loops and sedding in %check by using -Ilib:test for testrb. That way, teststrap will be on loadpath and will load ok.
- License seems to be MIT, not Ruby or GPLv2.
- File %{gem_instdir}/.yardopts is useless from Fedora POV and should be excluded.

Comment 3 Josef Stribny 2012-12-10 15:29:21 UTC

Thanks for the comments, I will keep them in my mind for the next time.

Updated spec & srpm:

Spec URL: http://data-strzibny.rhcloud.com/rubygem-riot.spec
SRPM URL: http://data-strzibny.rhcloud.com/rubygem-riot-0.12.5-2.fc19.src.rpm

Comment 4 Bohuslav "Slavek" Kabrda 2012-12-19 07:55:34 UTC

Looks good now, APPROVED.

Comment 5 Josef Stribny 2012-12-19 09:26:29 UTC

New Package SCM Request
=======================
Package Name: rubygem-riot
Short Description: An extremely fast, expressive, and context-driven unit-testing framework
Owners: jstribny
Branches: 
InitialCC:

Comment 6 Gwyn Ciesla 2012-12-19 12:24:05 UTC

Git done (by process-git-requests).