Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://data-strzibny.rhcloud.com/rubygem-riot.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-riot-0.12.5-1.fc19.src.rpm Description: An extremely fast, expressive, and context-driven unit-testing framework. A replacement for all other testing frameworks. Protest the slow test. Fedora Account System Username: jstribny Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4762910
I'll take this for a review.
- %{gem_instdir}/MIT-LICENSE should be marked as %doc - It is customary to keep %{gem_instdir}/%{gem_name}.gemspec in the -doc subpackage, but not mandatory, so this is not a blocker. - You can avoid the for loops and sedding in %check by using -Ilib:test for testrb. That way, teststrap will be on loadpath and will load ok. - License seems to be MIT, not Ruby or GPLv2. - File %{gem_instdir}/.yardopts is useless from Fedora POV and should be excluded.
Thanks for the comments, I will keep them in my mind for the next time. Updated spec & srpm: Spec URL: http://data-strzibny.rhcloud.com/rubygem-riot.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-riot-0.12.5-2.fc19.src.rpm
Looks good now, APPROVED.
New Package SCM Request ======================= Package Name: rubygem-riot Short Description: An extremely fast, expressive, and context-driven unit-testing framework Owners: jstribny Branches: InitialCC:
Git done (by process-git-requests).