Bug 885410

Summary:	libvirt should not chown ISO's
Product:	[Community] Virtualization Tools	Reporter:	Jeremy Bicha <jbicha>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	dyuan, jtomko, mprivozn, mzhan, rbalakri, zhwang
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-31 11:26:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeremy Bicha 2012-12-09 06:55:32 UTC

Description of problem:
libvirt chown ISO's to the qemu system user, which breaks the tool I use to downwload Ubuntu daily images.

Version-Release number of selected component (if applicable):
libvirt 1.0.0-0ubuntu3 on Ubuntu 13.04 Alpha

Steps to Reproduce:
1. Use virt-manager to boot an ISO from your home directory.
2. ls -lh reveals that the ownership of the ISO has changed to libvirt-qemu:kvm (on Fedora, it may be qemu:qemu)
  
Expected results:
Since an iso is read-only like a regular CD, there shouldn't be any need for libvirt to chown the ISO just to read it.

Additional info:
This bug was discussed as the actual root cause for bug 517304 but it was basically worked around instead.

Comment 1 Cole Robinson 2014-02-09 17:44:40 UTC

*** Bug 972997 has been marked as a duplicate of this bug. ***

Comment 2 Ján Tomko 2015-03-19 07:13:58 UTC

This can be worked around by adding:
<seclabel model='dac' relabel='no'/>
to the disk's source since:
commit 3c2487ab0aaf400ca85866f31a7f5b413afd2ce7
Author:     Jim Fehlig <jfehlig>
AuthorDate: 2014-05-15 15:30:26 -0600
Commit:     Jim Fehlig <jfehlig>
CommitDate: 2014-05-16 15:32:14 -0600

    security_dac: honor relabel='no' in disk config
    
    https://bugzilla.redhat.com/show_bug.cgi?id=999301
    
    The DAC driver ignores the relabel='no' attribute in disk config
    
      <disk type='file' device='floppy'>
        <driver name='qemu' type='raw'/>
        <source file='/some/path/floppy.img'>
          <seclabel model='dac' relabel='no'/>
        </source>
        <target dev='fda' bus='fdc'/>
        <readonly/>
      </disk>
    
    This patch avoid labeling disks when relabel='no' is specified.
    
    Signed-off-by: Michal Privoznik <mprivozn>
    Signed-off-by: Jim Fehlig <jfehlig>

git describe: v1.2.4-85-g3c2487a contains: v1.2.5-rc1~44

Comment 3 Michal Privoznik 2015-03-31 11:26:21 UTC

Closing per comment 2.