Bug 885548

Invalid srpm URL.

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[-]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.

$ rpmlint ./perl-DateTime-Tiny.spec ./perl-DateTime-Tiny-1.04-1.fc19.*.rpm
perl-DateTime-Tiny.noarch: E: description-line-too-long C DateTime::Tiny implements an extremely lightweight object that represents a datetime.
perl-DateTime-Tiny.noarch: E: incorrect-fsf-address /usr/share/doc/perl-DateTime-Tiny-1.04/LICENSE
perl-DateTime-Tiny.src: E: description-line-too-long C DateTime::Tiny implements an extremely lightweight object that represents a datetime.
2 packages and 1 specfiles checked; 3 errors, 0 warnings.

TODO: Description lines must not exceed 79 characters. Please cut it to fit in
two lines.

$ rpm -qp --requires perl-DateTime-Tiny-1.04-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(Test::More) >= 0.47
      1 perl(overload)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Add requires perl(DateTime) - ./lib/DateTime/Tiny.pm:355

$ rpm -qp --provides perl-DateTime-Tiny-1.04-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(DateTime::Tiny) = 1.04
      1 perl-DateTime-Tiny = 1.04-1.fc19
Provides are ok

MD5-sum check
-------------
http://www.cpan.org/authors/id/A/AD/ADAMK/DateTime-Tiny-1.04.tar.gz :
  CHECKSUM(SHA256) this package     : 68137c8ab3ca2a7f8a5fcea20f94b2f82bc2c7c36bb45063dbd81faadf0c7881
  CHECKSUM(SHA256) upstream package : 68137c8ab3ca2a7f8a5fcea20f94b2f82bc2c7c36bb45063dbd81faadf0c7881


Generated by fedora-review 0.3.1 (93e63af) last change: 2012-11-30
Buildroot used: fedora-rawhide-x86_64

Issues:
=======
FIX: Add requires perl(DateTime) - ./lib/DateTime/Tiny.pm:355
FIX: Remove perl(Test::More) from Requires, it is necessary only for build-time.
FIX: Description lines must not exceed 79 characters. Please cut it to fit in
two lines.

Please, correct the above and provide new spec file
Package is not approved.

Spec URL: http://cheeselee.fedorapeople.org/perl-DateTime-Tiny.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-DateTime-Tiny-1.04-2.fc18.src.rpm
Changes:
- Add requires perl(DateTime)
- Remove perl(Test::More) from Requires
- Fill description paragraph

Changes in spec:

-Requires:       perl(Test::More) >= 0.47
+Requires:       perl(DateTime)
> FIX: Add requires perl(DateTime) - ./lib/DateTime/Tiny.pm:355
> FIX: Remove perl(Test::More) from Requires, it is necessary only for build-time.
Ok.

-DateTime::Tiny implements an extremely lightweight object that represents a datetime.
+DateTime::Tiny implements an extremely lightweight object that represents a
+datetime.

> FIX: Description lines must not exceed 79 characters. Please cut it to fit in
> two lines.
Ok.


TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
%install.
TODO: Remove the deleting empty directories in %install section. This is
default behavior.

Please consider fixing 'TODO' items before submit.

Package APPROVED.

Thanks! I will clean up the TODOs.

New Package SCM Request
=======================
Package Name: perl-DateTime-Tiny
Short Description: Date object, with as little code as possible
Owners: cheeselee
Branches: f17 f18
InitialCC: perl-sig

Git done (by process-git-requests).

perl-DateTime-Tiny-1.04-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-DateTime-Tiny-1.04-2.fc17

perl-DateTime-Tiny-1.04-2.fc17 has been pushed to the Fedora 17 testing repository.

perl-DateTime-Tiny-1.04-2.fc17 has been pushed to the Fedora 17 stable repository.