Bug 885888
| Summary: | Swift initscript has empty "reload" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Pete Zaitcev <zaitcev> | ||||
| Component: | openstack-swift | Assignee: | Alan Pevec <apevec> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Attila Fazekas <afazekas> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | unspecified | CC: | fpercoco | ||||
| Target Milestone: | snapshot2 | Keywords: | Triaged | ||||
| Target Release: | 2.1 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | openstack-swift-1.7.4-7.el6ost | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-02-14 18:23:13 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 678826 [details]
Removed reload from init scripts
I removed reload from every init script in order to keep consistency between them. It could be added again for scripts that we do have something to execute in that clause.
swift-init -h .... reload: graceful shutdown then restart on supporting servers .... -g, --graceful send SIGHUP to supporting servers Our initscript using the SIGTERM which means stopping services without letting the workers to finish serving the in-progress requests. So the reload should use -1 SIGHUP instead of SIGTERM and it is a big difference. This is exactly why Flavio's approach is correct: don't fool people into thinking that our scripted reload does it correctly. They can use swift-init to do it. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0260.html |
Description of problem: "service openstack-swift-proxy reload" does nothing Version-Release number of selected component (if applicable): 1.7.4-2 Additional info: restart) $1 ;; reload) ;; It should invoke swift-init all reload or something. Failing that, just remove the clause and let the script error out.