Bug 886230
| Summary: | Review Request: php-phpass - Portable password hashing framework for use in PHP applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gregor Tätzner <gregor> |
| Component: | Package Review | Assignee: | Joseph Marrero <jmarrero> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, jmarrero, kevin, notting, package-review |
| Target Milestone: | --- | Flags: | jmarrero:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-01-20 03:11:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 858841 | ||
|
Description
Gregor Tätzner
2012-12-11 20:43:22 UTC
I don't understand the
cp -a %{SOURCE0} README.devel
Why do you want to provide the source tarball as a readme file ?
Please run the provided test
BuildRequires: php-cli
%check
php test.php | grep PASSED
I don't really agree on the need of a devel sub-package.
Simply add the test.php file and c directory to the %doc of the main package.
(not a blocker, packager choice)
Spec URL: http://brummbq.fedorapeople.org/php-phpass.spec SRPM URL: http://brummbq.fedorapeople.org/php-phpass-0.3-2.fc17.src.rpm (In reply to comment #1) > I don't understand the > cp -a %{SOURCE0} README.devel > > Why do you want to provide the source tarball as a readme file ? You can't understand that, because it's utter nonsense: I forgot to list the README file in SOURCES and used the first source as README erroneously :) > > Please run the provided test > > BuildRequires: php-cli > > %check > php test.php | grep PASSED > > I don't really agree on the need of a devel sub-package. > Simply add the test.php file and c directory to the %doc of the main package. > (not a blocker, packager choice) agreed, there are just a few files anyway. rpmlint output: php-phpass.src: W: spelling-error %description -l en_US bcrypt -> crypt, b crypt 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -------------------- NO real errors found with rpm lint Macros OK Licence OK Installs OK No blockers. APPROVED. New Package SCM Request ======================= Package Name: php-phpass Short Description: Portable password hashing framework for use in PHP applications Owners: brummbq Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). php-phpass-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc17 php-phpass-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc18 php-phpass-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.el6 php-phpass-0.3-2.fc17 has been pushed to the Fedora 17 testing repository. php-phpass-0.3-2.fc18 has been pushed to the Fedora 18 stable repository. php-phpass-0.3-2.fc17 has been pushed to the Fedora 17 stable repository. php-phpass-0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |