Bug 886230 - Review Request: php-phpass - Portable password hashing framework for use in PHP applications
Summary: Review Request: php-phpass - Portable password hashing framework for use in P...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Joseph Marrero
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 858841
TreeView+ depends on / blocked
 
Reported: 2012-12-11 20:43 UTC by Gregor Tätzner
Modified: 2013-01-22 03:37 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-20 03:11:29 UTC
jmarrero: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Gregor Tätzner 2012-12-11 20:43:22 UTC
Spec URL: http://brummbq.fedorapeople.org/php-phpass.spec
SRPM URL: http://brummbq.fedorapeople.org/php-phpass-0.3-1.fc17.src.rpm
Description:
phpass (pronounced "pH pass") is a portable public domain password hashing
framework for use in PHP applications. It is meant to work with PHP 3 and
above.

The preferred (most secure) hashing method supported by phpass is the
OpenBSD-style Blowfish-based bcrypt and known in PHP as CRYPT_BLOWFISH, with
a fallback to BSDI-style extended DES-based hashes, known in PHP as
CRYPT_EXT_DES, and a last resort fallback to MD5-based salted and variable
iteration count password hashes implemented in phpass
itself (also referred to as portable hashes).
Fedora Account System Username: brummbq

Comment 1 Remi Collet 2012-12-15 16:39:44 UTC
I don't understand the 
cp -a %{SOURCE0} README.devel

Why do you want to provide the source tarball as a readme file ?

Please run the provided test

BuildRequires: php-cli

%check
php test.php | grep PASSED

I don't really agree on the need of a devel sub-package.
Simply add the test.php file and c directory to the %doc of the main package.
(not a blocker, packager choice)

Comment 2 Gregor Tätzner 2012-12-16 11:06:05 UTC
Spec URL: http://brummbq.fedorapeople.org/php-phpass.spec
SRPM URL: http://brummbq.fedorapeople.org/php-phpass-0.3-2.fc17.src.rpm

(In reply to comment #1)
> I don't understand the 
> cp -a %{SOURCE0} README.devel
> 
> Why do you want to provide the source tarball as a readme file ?

You can't understand that, because it's utter nonsense: I forgot to list the README file in SOURCES and used the first source as README erroneously :)

> 
> Please run the provided test
> 
> BuildRequires: php-cli
> 
> %check
> php test.php | grep PASSED
> 
> I don't really agree on the need of a devel sub-package.
> Simply add the test.php file and c directory to the %doc of the main package.
> (not a blocker, packager choice)

agreed, there are just a few files anyway.

Comment 3 Joseph Marrero 2012-12-18 01:28:48 UTC
rpmlint output:

php-phpass.src: W: spelling-error %description -l en_US bcrypt -> crypt, b crypt
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
--------------------
NO real errors found with rpm lint
Macros OK
Licence OK

Installs OK

No blockers.



APPROVED.

Comment 4 Gregor Tätzner 2012-12-18 11:26:10 UTC
New Package SCM Request
=======================
Package Name: php-phpass
Short Description: Portable password hashing framework for use in PHP applications
Owners: brummbq
Branches: f17 f18 el6
InitialCC:

Comment 5 Gwyn Ciesla 2012-12-18 13:41:28 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2012-12-18 19:07:27 UTC
php-phpass-0.3-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc17

Comment 7 Fedora Update System 2012-12-18 19:07:55 UTC
php-phpass-0.3-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc18

Comment 8 Fedora Update System 2012-12-18 19:08:26 UTC
php-phpass-0.3-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-phpass-0.3-2.el6

Comment 9 Fedora Update System 2012-12-19 08:39:31 UTC
php-phpass-0.3-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 10 Fedora Update System 2013-01-20 03:11:32 UTC
php-phpass-0.3-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 11 Fedora Update System 2013-01-20 03:37:42 UTC
php-phpass-0.3-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 12 Fedora Update System 2013-01-22 03:37:40 UTC
php-phpass-0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.