Bug 88662

Summary: desktop-file-validate stops checking if the Encoding key is present
Product: [Retired] Red Hat Linux Reporter: Ville Skyttä <scop>
Component: desktop-file-utilsAssignee: Havoc Pennington <hp>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 9CC: wtogami
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2003-07-30 20:20:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Continue checking even if Encoding is present... :) none

Description Ville Skyttä 2003-04-11 18:46:19 UTC
desktop-file-validate from desktop-file-utils-0.3-5 incorrectly stops checking
if the Encoding key is present in the checked .desktop file, no matter if the
value is correct or not.

This is due to a spurious "return FALSE" statement that should be either in the
same block as the fatal error output about the invalid encoding, or just plain
removed.  I think the latter approach is the correct one.

I'll attach a patch, please apply.

Comment 1 Ville Skyttä 2003-04-11 18:48:26 UTC
Created attachment 91078 [details]
Continue checking even if Encoding is present... :)

Comment 2 Havoc Pennington 2003-04-11 21:15:45 UTC
Fixed in CVS now, thanks very much:

2003-04-11  Havoc Pennington  <hp@redhat.com>

	* src/validate.c (required_keys): don't stop checking as soon as
	we see an Encoding field. Fix from Ville Skytta
	<ville.skytta@iki.fi>

Leaving the bug open so I remember to build in rawhide.


Comment 3 Havoc Pennington 2003-07-30 20:20:45 UTC
Alex or Jonathan already built this in rawhide I believe.