Bug 88662 - desktop-file-validate stops checking if the Encoding key is present
Summary: desktop-file-validate stops checking if the Encoding key is present
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: desktop-file-utils
Version: 9
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-04-11 18:46 UTC by Ville Skyttä
Modified: 2007-04-18 16:52 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-07-30 20:20:45 UTC

Attachments (Terms of Use)
Continue checking even if Encoding is present... :) (343 bytes, patch)
2003-04-11 18:48 UTC, Ville Skyttä 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description Ville Skyttä 2003-04-11 18:46:19 UTC 
desktop-file-validate from desktop-file-utils-0.3-5 incorrectly stops checking
if the Encoding key is present in the checked .desktop file, no matter if the
value is correct or not.

This is due to a spurious "return FALSE" statement that should be either in the
same block as the fatal error output about the invalid encoding, or just plain
removed.  I think the latter approach is the correct one.

I'll attach a patch, please apply.
Comment 1 Ville Skyttä 2003-04-11 18:48:26 UTC 
Created attachment 91078 [details]
Continue checking even if Encoding is present... :)
Comment 2 Havoc Pennington 2003-04-11 21:15:45 UTC 
Fixed in CVS now, thanks very much:

2003-04-11  Havoc Pennington  <hp@redhat.com>

	* src/validate.c (required_keys): don't stop checking as soon as
	we see an Encoding field. Fix from Ville Skytta
	<ville.skytta@iki.fi>

Leaving the bug open so I remember to build in rawhide.
Comment 3 Havoc Pennington 2003-07-30 20:20:45 UTC 
Alex or Jonathan already built this in rawhide I believe.
Note You need to log in before you can comment on or make changes to this bug.