Red Hat Bugzilla – Bug 88662
desktop-file-validate stops checking if the Encoding key is present
Last modified: 2007-04-18 12:52:59 EDT
desktop-file-validate from desktop-file-utils-0.3-5 incorrectly stops checking
if the Encoding key is present in the checked .desktop file, no matter if the
value is correct or not.
This is due to a spurious "return FALSE" statement that should be either in the
same block as the fatal error output about the invalid encoding, or just plain
removed. I think the latter approach is the correct one.
I'll attach a patch, please apply.
Created attachment 91078 [details]
Continue checking even if Encoding is present... :)
Fixed in CVS now, thanks very much:
2003-04-11 Havoc Pennington <firstname.lastname@example.org>
* src/validate.c (required_keys): don't stop checking as soon as
we see an Encoding field. Fix from Ville Skytta
Leaving the bug open so I remember to build in rawhide.
Alex or Jonathan already built this in rawhide I believe.