Bug 887511
| Summary: | PyQt4 0.9.6 build regression in calibre | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> | ||||||
| Component: | calibre | Assignee: | Kevin Fenzi <kevin> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 18 | CC: | chkr, dmalcolm, kevin, mbacovsk, nushio, rdieter, sysoutfran, than | ||||||
| Target Milestone: | --- | Keywords: | Regression | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | calibre-0.9.9-2 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-12-17 15:48:54 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 664112 [details]
diff between .py output from 0.9.5 and 0.9.6
yuck, certainly smells a lot like a regression, i'll go poking upstream. Looks like some change in pyqt behavior that is fixed in calibre upstream it would appear, and this looks like the fix: http://bazaar.launchpad.net/~kovid/calibre/trunk/revision/13885 I committed the fix to rawhide, %changelog * Mon Dec 17 2012 Rex Dieter <rdieter> 0.9.9-2 - PyQt4 0.9.6 build regression in calibre (#887511) |
Created attachment 664111 [details] adv_search_builder.ui file. Using PyQt4-0.9.5, calibre builds fine. With 0.9.6 builds fail. The problem seems to be changes in the .py files generated from ui files no longer being byte compileable: + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 Bytecompiling .py files below /home/fedora/kevin/rpm/BUILDROOT/calibre-0.9.10-1.fc19.x86_64/usr/lib/python2.7/ using /usr/bin/python2.7 Compiling /home/fedora/kevin/rpm/BUILDROOT/calibre-0.9.10-1.fc19.x86_64/usr/lib64/calibre/calibre/gui2/store/config/chooser/adv_search_builder_ui.py ... SyntaxError: ('invalid syntax', ('/usr/lib64/calibre/calibre/gui2/store/config/chooser/adv_search_builder_ui.py', 21, 36, ' return _("Advanced Search"))\n')) The ui file is the same in both cases. I will attach that, and the diff of the .py file from the two builds (one working with 0.9.5 and one failing with 0.9.6). Is this a regression in 0.9.6? Or something calibre is doing wrong?