Bug 887511 - PyQt4 0.9.6 build regression in calibre
Summary: PyQt4 0.9.6 build regression in calibre
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: calibre
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-12-15 20:03 UTC by Kevin Fenzi
Modified: 2012-12-17 15:48 UTC (History)
8 users (show)

Fixed In Version: calibre-0.9.9-2
Clone Of:
Environment:
Last Closed: 2012-12-17 15:48:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
adv_search_builder.ui file. (12.59 KB, text/plain)
2012-12-15 20:03 UTC, Kevin Fenzi
no flags Details
diff between .py output from 0.9.5 and 0.9.6 (16.31 KB, text/plain)
2012-12-15 20:05 UTC, Kevin Fenzi
no flags Details

Description Kevin Fenzi 2012-12-15 20:03:18 UTC
Created attachment 664111 [details]
adv_search_builder.ui file.

Using PyQt4-0.9.5, calibre builds fine. 
With 0.9.6 builds fail. 

The problem seems to be changes in the .py files generated from ui files no longer being byte compileable: 

+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
Bytecompiling .py files below /home/fedora/kevin/rpm/BUILDROOT/calibre-0.9.10-1.fc19.x86_64/usr/lib/python2.7/ using /usr/bin/python2.7
Compiling /home/fedora/kevin/rpm/BUILDROOT/calibre-0.9.10-1.fc19.x86_64/usr/lib64/calibre/calibre/gui2/store/config/chooser/adv_search_builder_ui.py ...
SyntaxError: ('invalid syntax', ('/usr/lib64/calibre/calibre/gui2/store/config/chooser/adv_search_builder_ui.py', 21, 36, '        return _("Advanced Search"))\n'))

The ui file is the same in both cases. I will attach that, and the diff of the .py file from the two builds (one working with 0.9.5 and one failing with 0.9.6). 

Is this a regression in 0.9.6? Or something calibre is doing wrong?

Comment 1 Kevin Fenzi 2012-12-15 20:05:22 UTC
Created attachment 664112 [details]
diff between .py output from 0.9.5 and 0.9.6

Comment 2 Rex Dieter 2012-12-16 22:08:37 UTC
yuck, certainly smells a lot like a regression, i'll go poking upstream.

Comment 3 Rex Dieter 2012-12-17 15:48:54 UTC
Looks like some change in pyqt behavior that is fixed in calibre upstream it would appear, and this looks like the fix:

http://bazaar.launchpad.net/~kovid/calibre/trunk/revision/13885

I committed the fix to rawhide,

%changelog
* Mon Dec 17 2012 Rex Dieter <rdieter> 0.9.9-2
- PyQt4 0.9.6 build regression in calibre (#887511)


Note You need to log in before you can comment on or make changes to this bug.