Bug 888258

Summary: libvirtd doesn't restart after vdsm configures it
Product: [Retired] oVirt Reporter: Ohad Basan <obasan>
Component: vdsmAssignee: Yaniv Bronhaim <ybronhei>
Status: CLOSED CURRENTRELEASE QA Contact: Haim <hateya>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 3.2CC: abaron, acathrow, alonbl, bazulay, danken, dyasny, eedri, iheim, mgoldboi, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-15 06:47:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 881006    
Attachments:
Description Flags
engine-setup.log
none
host deploy log
none
vdsm.log none

Description Ohad Basan 2012-12-18 12:12:23 UTC 
Description of problem:
After host-deploy libvirtd should be restarted prior to starting vdsmd.
in order for it to load the new configuration


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.install a fedora18 + ovirt nightly.
2.connect a new host.
3.
  
Actual results:
vdsm crashes because libvirtd wasn't restarted before that.

Expected results:
libvirtd should be restarted after being configured.

Additional info:
Comment 1 Moran Goldboim 2012-12-18 14:30:30 UTC 
blocks ovirt live flow.
Comment 2 Alon Bar-Lev 2012-12-18 21:14:11 UTC 
Ohad, this is not full description.

You should have written that ovirt-host-deploy executes vdsm reconfigure, this succeeds, and still there is an issue with vdsm/libvirt, even paste the relevant log hank.

You should have come up with Dan analyze of the problem, as he did invest time.
Comment 3 Ohad Basan 2012-12-19 09:16:22 UTC 
Created attachment 665986 [details]
engine-setup.log
Comment 4 Ohad Basan 2012-12-19 09:16:49 UTC 
Created attachment 665987 [details]
host deploy log
Comment 5 Dan Kenigsberg 2012-12-19 09:20:08 UTC 
I am guessing that vdsmd.service failed to restart libvirt after having /etc/libvirtd.conf reconfigured.

You can verify my guess by applying the following untested patch, and rebuild vdsm:

diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in
index 7a7ae84..86edc15 100755
--- a/vdsm/vdsmd.init.in
+++ b/vdsm/vdsmd.init.in
@@ -362,7 +362,11 @@ EOF
 
     ovirt_store_config "$lconf" "$qconf" "$ldconf" "$llogr"
 
-    /sbin/initctl restart libvirtd 2>/dev/null || :
+    if libvirt_should_use_upstart; then
+        /sbin/initctl restart libvirtd 2>/dev/null || :
+    else
+        systemctl reload libvirtd.service
+    fi
 
     #
     # finished reconfiguration, do not trigger
Comment 6 Ohad Basan 2012-12-19 10:22:23 UTC 
Created attachment 666012 [details]
vdsm.log

this patch doesn't seem to be working. log is attached.
Comment 7 Yaniv Bronhaim 2012-12-25 13:10:06 UTC 
merged upstream - http://gerrit.ovirt.org/#/c/10237/
posted for 3.2 branch - http://gerrit.ovirt.org/#/c/10316/
Comment 8 Itamar Heim 2013-01-16 16:10:26 UTC 
3.2 beta built, moving to ON_QA status to allow testing