Bug 888385

New version that requires at build time both python-setuptools (v2 and v3).

Spec URL: http://jamatos.fedorapeople.org/python-yapsy.spec
SRPM URL: http://jamatos.fedorapeople.org/python-yapsy-1.9.2-2.fc18.src.rpm

Hello Jose Matos, I'm not officially packager, but I want do a informal review at your package. :)

there are a issue in the test with rpmlint to file .rpm, here is the output

$ rpmlint python-yapsy-1.9.2-2.fc19.noarch.rpm 
python-yapsy.noarch: W: spelling-error %description -l en_US customised -> customized, customize, accustomed
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/AutoInstallPluginManager.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginInfo.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManager.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/ConfigurablePluginManager.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/IPlugin.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManagerDecorator.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/FilteredPluginManager.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/VersionedPluginManager.py 0644L /usr/bin/python
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/__init__.py 0644L /usr/bin/python
1 packages and 0 specfiles checked; 9 errors, 1 warnings.

Good luck!

The tarball contains an upstream egg, you have to delete it before building the package so that it gets rebuilt:

%prep
%setup -q -n Yapsy-%{version}-pythons2n3
rm -rf *.egg-info

See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more info.

Don't mix %{buildroot} and $RPM_BUILD_ROOT in the same spec file.


$ rpmlint -i -v *
python-yapsy.src: I: checking
python-yapsy.src: W: spelling-error %description -l en_US customised -> customized, customize, accustomed
The value of this tag appears to be misspelled. Please double-check.

Please fix the spelling error:
customised → customized

(In reply to Mario Blättermann from comment #3)
> The tarball contains an upstream egg, you have to delete it before building
> the package so that it gets rebuilt:
> 
> %prep
> %setup -q -n Yapsy-%{version}-pythons2n3
> rm -rf *.egg-info
> 
> See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for
> more info.

I noticed it the first time but forgot to remove it. Mea culpa. :-)

> Don't mix %{buildroot} and $RPM_BUILD_ROOT in the same spec file.

I was surprised when I noticed the $ version in there. :-)

> $ rpmlint -i -v *
> python-yapsy.src: I: checking
> python-yapsy.src: W: spelling-error %description -l en_US customised ->
> customized, customize, accustomed
> The value of this tag appears to be misspelled. Please double-check.
> 
> Please fix the spelling error:
> customised → customized

Done.

I have updated the package to the latest stable version together with all the fixes you proposed.

Spec URL: http://jamatos.fedorapeople.org/python-yapsy.spec
SRPM URL: http://jamatos.fedorapeople.org/python-yapsy-1.10.2-1.fc20.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5530158

$ rpmlint -i -v *
python3-yapsy.noarch: I: checking
python3-yapsy.noarch: I: checking-url http://yapsy.sourceforge.net/ (timeout 10 seconds)
python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/PluginInfo.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/ConfigurablePluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/IPlugin.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/VersionedPluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/__init__.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/PluginManagerDecorator.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/PluginFileLocator.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/AutoInstallPluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/PluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/FilteredPluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-yapsy.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/yapsy/IPluginLocator.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: I: checking
python-yapsy.noarch: I: checking-url http://yapsy.sourceforge.net/ (timeout 10 seconds)
python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/AutoInstallPluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/IPluginLocator.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginInfo.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/ConfigurablePluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/IPlugin.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManagerDecorator.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/FilteredPluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/VersionedPluginManager.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/__init__.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginFileLocator.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-yapsy.src: I: checking
python-yapsy.src: I: checking-url http://yapsy.sourceforge.net/ (timeout 10 seconds)
python-yapsy.src: I: checking-url http://downloads.sourceforge.net/yapsy/Yapsy-1.10.2/Yapsy-1.10.2-pythons2n3.tar.gz (timeout 10 seconds)
python-yapsy.spec: I: checking-url http://downloads.sourceforge.net/yapsy/Yapsy-1.10.2/Yapsy-1.10.2-pythons2n3.tar.gz (timeout 10 seconds)
3 packages and 1 specfiles checked; 22 errors, 0 warnings.


Usually, the scripts in %{python_sitelib} and %{python3_sitelib} don't need to be executable and don't need a shebang. Please remove the shebangs, and your package is ready for a full review.

Any news here...?

Looks like another review overtook this one, see bug 998738

*** This bug has been marked as a duplicate of bug 998738 ***

Sorry I missed this, José - I would welcome you as a comaintainer.