Spec URL: http://immanetize.fedorapeople.org/python-yapsy.spec SRPM URL: http://immanetize.fedorapeople.org/python-yapsy-1.10.2-1.src.rpm Description: Yapsy’s main purpose is to offer a way to easily design a plugin system in Python. Yapsy only depends on Python's standard library. Python. Yapsy only depends on Python’s standard library. Fedora Account System Username: immanetize
Invalid: 1. Release: 1 ---> Missing dist macro 2. License: BSD, CC-BY-SA ---> Please follow the licensing guideline and fix, but DO NOT use any comma. 3. BuildRequires: python --->BuildRequires: python2-devel Also remove the trailing space. 4. Where? %package -n python3-yapsy-doc Summary: Documentation for python2-yapsy, a plugin system for Python3 applications. Group: Development/Libraries %description -n python3-yapsy-doc Documentation for yapsy, a simple plugin system for python3 applications. %endif I strongly recommend you generate one NOARCH doc subpackage for py2.7 and py3.x 5. What??!! %files %dir %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/ %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/PKG-INFO %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/SOURCES.txt %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/dependency_links.txt %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/top_level.txt %dir %{python_sitelib}/%{productname}/ %{python_sitelib}/%{productname}/AutoInstallPluginManager.py %{python_sitelib}/%{productname}/AutoInstallPluginManager.pyc %{python_sitelib}/%{productname}/AutoInstallPluginManager.pyo %{python_sitelib}/%{productname}/ConfigurablePluginManager.py %{python_sitelib}/%{productname}/ConfigurablePluginManager.pyc %{python_sitelib}/%{productname}/ConfigurablePluginManager.pyo %{python_sitelib}/%{productname}/FilteredPluginManager.py %{python_sitelib}/%{productname}/FilteredPluginManager.pyc %{python_sitelib}/%{productname}/FilteredPluginManager.pyo %{python_sitelib}/%{productname}/IPlugin.py %{python_sitelib}/%{productname}/IPlugin.pyc %{python_sitelib}/%{productname}/IPlugin.pyo %{python_sitelib}/%{productname}/IPluginLocator.py %{python_sitelib}/%{productname}/IPluginLocator.pyc %{python_sitelib}/%{productname}/IPluginLocator.pyo %{python_sitelib}/%{productname}/PluginFileLocator.py %{python_sitelib}/%{productname}/PluginFileLocator.pyc %{python_sitelib}/%{productname}/PluginFileLocator.pyo %{python_sitelib}/%{productname}/PluginInfo.py %{python_sitelib}/%{productname}/PluginInfo.pyc %{python_sitelib}/%{productname}/PluginInfo.pyo %{python_sitelib}/%{productname}/PluginManager.py %{python_sitelib}/%{productname}/PluginManager.pyc %{python_sitelib}/%{productname}/PluginManager.pyo %{python_sitelib}/%{productname}/PluginManagerDecorator.py %{python_sitelib}/%{productname}/PluginManagerDecorator.pyc %{python_sitelib}/%{productname}/PluginManagerDecorator.pyo %{python_sitelib}/%{productname}/VersionedPluginManager.py %{python_sitelib}/%{productname}/VersionedPluginManager.pyc %{python_sitelib}/%{productname}/VersionedPluginManager.pyo %{python_sitelib}/%{productname}/__init__.py %{python_sitelib}/%{productname}/__init__.pyc %{python_sitelib}/%{productname}/__init__.pyo is ugly, change to: %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py%{python_version}.egg-info %{python_sitelib}/%{productname}
Hey Christopher, thanks for picking this up! (In reply to Christopher Meng from comment #1) > Invalid: > > 1. Release: 1 ---> Missing dist macro > Added the macro. > 2. License: BSD, CC-BY-SA ---> Please follow the licensing guideline and > fix, but DO NOT use any comma. > s/,/ AND/ > 3. BuildRequires: python --->BuildRequires: python2-devel > Done. Can you help me understand why this is needed? It built without python2-devel. > Also remove the trailing space. > s/ $// > 4. Where? > > > %package -n python3-yapsy-doc > Summary: Documentation for python2-yapsy, a plugin system for Python3 > applications. > Group: Development/Libraries > %description -n python3-yapsy-doc > Documentation for yapsy, a simple plugin system for python3 applications. > %endif > > I strongly recommend you generate one NOARCH doc subpackage for py2.7 and > py3.x Changed to use noarch doc subpackages. Upstream ships different doc trees for py2.7 and py3.x, so I want the spec to allow for them to be different. > 5. What??!! > > %files > %dir %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/ > %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/PKG- > INFO > %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/ > SOURCES.txt > %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/ > dependency_links.txt > %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/ > top_level.txt > %dir %{python_sitelib}/%{productname}/ > %{python_sitelib}/%{productname}/AutoInstallPluginManager.py > %{python_sitelib}/%{productname}/AutoInstallPluginManager.pyc > %{python_sitelib}/%{productname}/AutoInstallPluginManager.pyo > %{python_sitelib}/%{productname}/ConfigurablePluginManager.py > %{python_sitelib}/%{productname}/ConfigurablePluginManager.pyc > %{python_sitelib}/%{productname}/ConfigurablePluginManager.pyo > %{python_sitelib}/%{productname}/FilteredPluginManager.py > %{python_sitelib}/%{productname}/FilteredPluginManager.pyc > %{python_sitelib}/%{productname}/FilteredPluginManager.pyo > %{python_sitelib}/%{productname}/IPlugin.py > %{python_sitelib}/%{productname}/IPlugin.pyc > %{python_sitelib}/%{productname}/IPlugin.pyo > %{python_sitelib}/%{productname}/IPluginLocator.py > %{python_sitelib}/%{productname}/IPluginLocator.pyc > %{python_sitelib}/%{productname}/IPluginLocator.pyo > %{python_sitelib}/%{productname}/PluginFileLocator.py > %{python_sitelib}/%{productname}/PluginFileLocator.pyc > %{python_sitelib}/%{productname}/PluginFileLocator.pyo > %{python_sitelib}/%{productname}/PluginInfo.py > %{python_sitelib}/%{productname}/PluginInfo.pyc > %{python_sitelib}/%{productname}/PluginInfo.pyo > %{python_sitelib}/%{productname}/PluginManager.py > %{python_sitelib}/%{productname}/PluginManager.pyc > %{python_sitelib}/%{productname}/PluginManager.pyo > %{python_sitelib}/%{productname}/PluginManagerDecorator.py > %{python_sitelib}/%{productname}/PluginManagerDecorator.pyc > %{python_sitelib}/%{productname}/PluginManagerDecorator.pyo > %{python_sitelib}/%{productname}/VersionedPluginManager.py > %{python_sitelib}/%{productname}/VersionedPluginManager.pyc > %{python_sitelib}/%{productname}/VersionedPluginManager.pyo > %{python_sitelib}/%{productname}/__init__.py > %{python_sitelib}/%{productname}/__init__.pyc > %{python_sitelib}/%{productname}/__init__.pyo > > is ugly, change to: > > %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py%{python_version}. > egg-info > %{python_sitelib}/%{productname} *facepalm* Done, thanks.
Spec URL: http://immanetize.fedorapeople.org/python-yapsy.spec SRPM URL: http://immanetize.fedorapeople.org/python-yapsy-1.10.2-2.fc20.src.rpm Description: Yapsy’s main purpose is to offer a way to easily design a plugin system in Python. Yapsy only depends on Python's standard library.
Rpmlint (installed packages) ---------------------------- # rpmlint python-yapsy-doc python-yapsy python-yapsy-doc.noarch: W: invalid-url URL: http://yapsy.sourceforge.net <urlopen error timed out> python-yapsy.i686: W: invalid-url URL: http://yapsy.sourceforge.net <urlopen error timed out> python-yapsy.i686: E: no-binary python-yapsy.i686: W: no-documentation python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/AutoInstallPluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/IPluginLocator.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginInfo.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/ConfigurablePluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/IPlugin.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManagerDecorator.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/FilteredPluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/VersionedPluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/__init__.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginFileLocator.py 0644L /usr/bin/python Please remove shebangs.
Spec URL: http://immanetize.fedorapeople.org/python-yapsy.spec SRPM URL: http://immanetize.fedorapeople.org/python-yapsy-1.10.2-3.fc21.src.rpm Description: Yapsy’s main purpose is to offer a way to easily design a plugin system in Python. Yapsy only depends on Python's standard library.
Christopher, I have another package whose review is waiting for this dependency. Can you take a look at the updated files soon?
1. No need to Requires: python, RPM will add it. 2. python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/AutoInstallPluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/IPluginLocator.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginInfo.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/ConfigurablePluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/IPlugin.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginManagerDecorator.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/FilteredPluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/VersionedPluginManager.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/__init__.py 0644L /usr/bin/python python-yapsy.i686: E: non-executable-script /usr/lib/python2.7/site-packages/yapsy/PluginFileLocator.py 0644L /usr/bin/python Seems sed sentence is invalid?
I've updated the spec file and rebuild the src.rpm linked above to remove the harmless but unneeded declaration of Requires: python I can't reproduce complaints about non-executable scripts after stripping shebangs.
Replace %{__python} with %{__python2} (I just knew this). APPROVED.
New Package SCM Request ======================= Package Name: python-yapsy Short Description: A simple plugin system for Python applications Owners: immanetize Branches: f18 f19 f20 InitialCC:
Git done (by process-git-requests).
python-yapsy-1.10.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-yapsy-1.10.2-2.fc20
python-yapsy-1.10.2-2.fc20 has been pushed to the Fedora 20 testing repository.
It seems to me that the whole package should be noarch, not just the doc subpackages. Is there a reason it isn't? If there is, the -debuginfo package should be explicitly disabled.
*** Bug 888385 has been marked as a duplicate of this bug. ***
python-yapsy-1.10.2-2.fc20 has been pushed to the Fedora 20 stable repository.