Bug 889476 (kio-mtp)
| Summary: | Review Request: kio_mtp - An MTP KIO slave for KDE | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Daniel Vrátil <dvratil> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dvratil, hackemaier, jeischma, kevin, notting, package-review |
| Target Milestone: | --- | Flags: | dvratil:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-01-14 04:08:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Jan Grulich
2012-12-21 10:41:54 UTC
*** Bug 889474 has been marked as a duplicate of this bug. *** You don't have to run remove buildroot in %clean and you should ask upstream to include LICENSE file. Otherwise it looks good. So, as we've been discussing on IRC recently, I think this should be called kio_mtp rather than kio-mtp, but I'm not sure my opinion is the consensus. (See also the kio-upnp-ms review.) Updated ======= Spec URL: http://jgrulich.fedorapeople.org/kio_mtp.spec SRPM URL: http://jgrulich.fedorapeople.org/kio_mtp-0.70-2.20121225gitfae62fc.fc17.src.rpm * Thu Dec 25 2012 Jan Grulich <jgrulich> - 0.70-2.20121225gitfae62fc - Add LICENCE file - Remove %clean - Change name New Package SCM Request ======================= Package Name: kio_mtp Short Description: MTP KIO slave for KDE Owners: jgrulich Branches: f17 f18 InitialCC: rdieter dvratil A few items: 1. Please include checkout info for the source per: http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control 2. Package review guidelines list as a MUST adding the rpmlint output to the review. :) kio_mtp.src: E: invalid-spec-name (your spec in src.rpm still has the - instead of the _) kio_mtp.src:49: W: macro-in-%changelog %clean Should use %% :) kio_mtp.src: E: specfile-error warning: bogus date in %changelog: Thu Dec 25 2012 Jan Grulich <jgrulich> - 0.70-2.20121225gitfae62fc Tue? kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) kio -> oik, kip, kilo kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) mtp -> mt, mp, map kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US kio -> oik, kip, kilo kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US mtp -> mt, mp, map kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) kio -> oik, kip, kilo kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) mtp -> mt, mp, map kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US kio -> oik, kip, kilo kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US mtp -> mt, mp, map 5 packages and 0 specfiles checked; 2 errors, 9 warnings. Can all be ignored. ;) Git done (by process-git-requests). kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc17 kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc18 kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 testing repository. kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 stable repository. kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been pushed to the Fedora 17 stable repository. |