Bug 889476 (kio-mtp) - Review Request: kio_mtp - An MTP KIO slave for KDE
Summary: Review Request: kio_mtp - An MTP KIO slave for KDE
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: kio-mtp
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Vrátil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 889474 (view as bug list)
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2012-12-21 10:41 UTC by Jan Grulich
Modified: 2015-11-02 01:36 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-14 04:08:44 UTC
Type: ---
dvratil: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jan Grulich 2012-12-21 10:41:54 UTC
Spec URL: http://jgrulich.fedorapeople.org/kio-mtp.spec
SRPM URL: http://jgrulich.fedorapeople.org/kio-mtp-0.70-1.20121221gitccaa6d1.fc17.src.rpm
Description: Provides KIO Access to MTP devices. This KIO slave is necessary if you want access to MTP devices through application like Dolphin.
Fedora Account System Username: jgrulich

Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4810276

Comment 1 Jan Grulich 2012-12-21 10:58:38 UTC
*** Bug 889474 has been marked as a duplicate of this bug. ***

Comment 2 Daniel Vrátil 2012-12-23 18:54:03 UTC
You don't have to run remove buildroot in %clean and you should ask upstream to include LICENSE file. Otherwise it looks good.

Comment 3 Kevin Kofler 2012-12-24 01:54:02 UTC
So, as we've been discussing on IRC recently, I think this should be called kio_mtp rather than kio-mtp, but I'm not sure my opinion is the consensus.

Comment 4 Kevin Kofler 2012-12-24 14:43:46 UTC
(See also the kio-upnp-ms review.)

Comment 5 Jan Grulich 2012-12-26 10:39:28 UTC
Updated
=======

Spec URL: http://jgrulich.fedorapeople.org/kio_mtp.spec
SRPM URL: http://jgrulich.fedorapeople.org/kio_mtp-0.70-2.20121225gitfae62fc.fc17.src.rpm

* Thu Dec 25 2012 Jan Grulich <jgrulich@redhat.com> - 0.70-2.20121225gitfae62fc
- Add LICENCE file
- Remove %clean
- Change name

Comment 6 Jan Grulich 2012-12-27 13:51:36 UTC
New Package SCM Request
=======================
Package Name: kio_mtp
Short Description: MTP KIO slave for KDE
Owners: jgrulich
Branches: f17 f18
InitialCC: rdieter dvratil

Comment 7 Kevin Fenzi 2012-12-30 20:55:09 UTC
A few items: 

1. Please include checkout info for the source per:  
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

2. Package review guidelines list as a MUST adding the rpmlint output 
to the review. :) 

kio_mtp.src: E: invalid-spec-name

(your spec in src.rpm still has the - instead of the _)

kio_mtp.src:49: W: macro-in-%changelog %clean

Should use %% :) 

kio_mtp.src: E: specfile-error warning: bogus date in %changelog: Thu Dec 25 2012 Jan Grulich <jgrulich@redhat.com> - 0.70-2.20121225gitfae62fc

Tue? 

kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) kio -> oik, kip, kilo
kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) mtp -> mt, mp, map
kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US kio -> oik, kip, kilo
kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US mtp -> mt, mp, map
kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) kio -> oik, kip, kilo
kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) mtp -> mt, mp, map
kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US kio -> oik, kip, kilo
kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US mtp -> mt, mp, map
5 packages and 0 specfiles checked; 2 errors, 9 warnings.

Can all be ignored. ;)

Comment 8 Kevin Fenzi 2012-12-30 21:04:05 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2012-12-31 11:54:40 UTC
kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc17

Comment 10 Fedora Update System 2012-12-31 11:56:03 UTC
kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc18

Comment 11 Fedora Update System 2013-01-01 00:15:51 UTC
kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 testing repository.

Comment 12 Fedora Update System 2013-01-14 04:08:47 UTC
kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 stable repository.

Comment 13 Fedora Update System 2013-01-14 04:14:10 UTC
kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.