Spec URL: http://jgrulich.fedorapeople.org/kio-mtp.spec SRPM URL: http://jgrulich.fedorapeople.org/kio-mtp-0.70-1.20121221gitccaa6d1.fc17.src.rpm Description: Provides KIO Access to MTP devices. This KIO slave is necessary if you want access to MTP devices through application like Dolphin. Fedora Account System Username: jgrulich Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4810276
*** Bug 889474 has been marked as a duplicate of this bug. ***
You don't have to run remove buildroot in %clean and you should ask upstream to include LICENSE file. Otherwise it looks good.
So, as we've been discussing on IRC recently, I think this should be called kio_mtp rather than kio-mtp, but I'm not sure my opinion is the consensus.
(See also the kio-upnp-ms review.)
Updated ======= Spec URL: http://jgrulich.fedorapeople.org/kio_mtp.spec SRPM URL: http://jgrulich.fedorapeople.org/kio_mtp-0.70-2.20121225gitfae62fc.fc17.src.rpm * Thu Dec 25 2012 Jan Grulich <jgrulich> - 0.70-2.20121225gitfae62fc - Add LICENCE file - Remove %clean - Change name
New Package SCM Request ======================= Package Name: kio_mtp Short Description: MTP KIO slave for KDE Owners: jgrulich Branches: f17 f18 InitialCC: rdieter dvratil
A few items: 1. Please include checkout info for the source per: http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control 2. Package review guidelines list as a MUST adding the rpmlint output to the review. :) kio_mtp.src: E: invalid-spec-name (your spec in src.rpm still has the - instead of the _) kio_mtp.src:49: W: macro-in-%changelog %clean Should use %% :) kio_mtp.src: E: specfile-error warning: bogus date in %changelog: Thu Dec 25 2012 Jan Grulich <jgrulich> - 0.70-2.20121225gitfae62fc Tue? kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) kio -> oik, kip, kilo kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) mtp -> mt, mp, map kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US kio -> oik, kip, kilo kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US mtp -> mt, mp, map kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) kio -> oik, kip, kilo kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) mtp -> mt, mp, map kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US kio -> oik, kip, kilo kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US mtp -> mt, mp, map 5 packages and 0 specfiles checked; 2 errors, 9 warnings. Can all be ignored. ;)
Git done (by process-git-requests).
kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc17
kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc18
kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 testing repository.
kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 stable repository.
kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been pushed to the Fedora 17 stable repository.