Bug 890438 (libkscreen)
| Summary: | Review Request: libkscreen - KDE Display Management library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeischma, jgrulich, kevin, mario.blaettermann, notting, package-review |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-01-11 23:47:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 890439 | ||
|
Description
Daniel Vrátil
2012-12-26 23:15:34 UTC
Source0: libkscreen-%{version}.tar.xz
has to be a downloadable URL. You are using a Git checkout, that's why no static URL is available. In this case you have to provide instructions how to get the source tarball.
In general, you should follow the instructions for the naming of such checkouts:
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Pre-Release_packages
rm -rf $RPM_BUILD_ROOT
is an artifact from older Fedora releases. Drop it, unless you want to provide your package for EPEL5 (impossible anyway due to missing BuildRequires there).
URL: http://www.kde.org
Is it possible to provide a more specific URL?
Spec URL: http://pub.progdan.cz/specs/libkscreen.spec SRPM URL: http://pub.progdan.cz/specs/libkscreen-0.9.0-1.20121228git.fc18.src.rpm * Fri Dec 28 2012 Dan Vrátil <dvratil> 0.9.0-1.20121228git - Fixed versioning - Added instructions how to retrieve sources - Fixed URL - Removed 'rm -rf $RPM_BUILD_ROOT' Should be okay now. New Package SCM Request ======================= Package Name: libkscreen Short Description: KDE Display Management Library Owners: dvratil Branches: f17 f18 InitialCC: Git done (by process-git-requests). jgrulich: when doing reviews, could you do some basic checks, add rpmlint output, etc? (Or use the fedora-review tool as a base) libkscreen-0.9.0-1.20121228git.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libkscreen-0.9.0-1.20121228git.fc17 libkscreen-0.9.0-1.20121228git.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libkscreen-0.9.0-1.20121228git.fc18 libkscreen-0.9.0-1.20121228git.fc18 has been pushed to the Fedora 18 testing repository. There's no Rawhide package available yet, which I could use for a Koji build of kscreen. libkscreen-0.9.0-1.20121228git.fc18 has been pushed to the Fedora 18 stable repository. libkscreen-0.9.0-1.20121228git.fc17 has been pushed to the Fedora 17 stable repository. |