Bug 890438 (libkscreen) - Review Request: libkscreen - KDE Display Management library
Summary: Review Request: libkscreen - KDE Display Management library
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: libkscreen
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kscreen
TreeView+ depends on / blocked
 
Reported: 2012-12-26 23:15 UTC by Daniel Vrátil
Modified: 2015-11-02 01:36 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-11 23:47:48 UTC
Type: ---
jgrulich: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Vrátil 2012-12-26 23:15:34 UTC
Spec URL: http://pub.progdan.cz/specs/libkscreen.spec
SRPM URL: http://pub.progdan.cz/specs/libkscreen-20121226gitecc8d1a-1.fc18.src.rpm
Description: LibKScreen is a library to access and change current configuration of displays.
Fedora Account System Username: dvratil

Successful Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4820851

Comment 1 Mario Blättermann 2012-12-27 16:22:28 UTC
Source0:        libkscreen-%{version}.tar.xz
has to be a downloadable URL. You are using a Git checkout, that's why no static URL is available. In this case you have to provide instructions how to get the source tarball.
In general, you should follow the instructions for the naming of such checkouts:
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Pre-Release_packages

rm -rf $RPM_BUILD_ROOT
is an artifact from older Fedora releases. Drop it, unless you want to provide your package for EPEL5 (impossible anyway due to missing BuildRequires there).

URL:            http://www.kde.org
Is it possible to provide a more specific URL?

Comment 2 Daniel Vrátil 2012-12-28 16:30:09 UTC
Spec URL: http://pub.progdan.cz/specs/libkscreen.spec
SRPM URL: http://pub.progdan.cz/specs/libkscreen-0.9.0-1.20121228git.fc18.src.rpm

* Fri Dec 28 2012 Dan Vrátil <dvratil@redhat.com> 0.9.0-1.20121228git
 - Fixed versioning
 - Added instructions how to retrieve sources
 - Fixed URL
 - Removed 'rm -rf $RPM_BUILD_ROOT'

Comment 3 Jan Grulich 2012-12-28 17:13:37 UTC
Should be okay now.

Comment 4 Daniel Vrátil 2012-12-28 17:16:53 UTC
New Package SCM Request
=======================
Package Name: libkscreen
Short Description: KDE Display Management Library
Owners: dvratil
Branches: f17 f18
InitialCC:

Comment 5 Kevin Fenzi 2012-12-30 21:05:58 UTC
Git done (by process-git-requests).

jgrulich: when doing reviews, could you do some basic checks, add rpmlint output, etc? 
(Or use the fedora-review tool as a base)

Comment 6 Fedora Update System 2012-12-30 21:59:06 UTC
libkscreen-0.9.0-1.20121228git.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libkscreen-0.9.0-1.20121228git.fc17

Comment 7 Fedora Update System 2012-12-30 21:59:17 UTC
libkscreen-0.9.0-1.20121228git.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libkscreen-0.9.0-1.20121228git.fc18

Comment 8 Fedora Update System 2013-01-01 00:15:41 UTC
libkscreen-0.9.0-1.20121228git.fc18 has been pushed to the Fedora 18 testing repository.

Comment 9 Mario Blättermann 2013-01-04 21:12:16 UTC
There's no Rawhide package available yet, which I could use for a Koji build of kscreen.

Comment 10 Fedora Update System 2013-01-11 23:47:51 UTC
libkscreen-0.9.0-1.20121228git.fc18 has been pushed to the Fedora 18 stable repository.

Comment 11 Fedora Update System 2013-01-12 15:22:18 UTC
libkscreen-0.9.0-1.20121228git.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.