Bug 891080

Summary:	RHEVM-CLI: Wrong error when passing empty kwargs to CLI
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Oded Ramraz <oramraz>
Component:	ovirt-engine-cli	Assignee:	Michael Pasternak <mpastern>
Status:	CLOSED ERRATA	QA Contact:	Ilia Meerovich <iliam>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.2.0	CC:	bazulay, cboyle, dyasny, ecohen, iheim, oramraz, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone:	---
Target Release:	3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:	SF4	Doc Type:	Bug Fix
Doc Text:	When a command containing an empty keyword argument (kwarg) was used in the CLI, an incorrect error message was displayed -'unknown error: need more than 1 value to unpack'. The message did not clearly show what the problem was. The error message now correctly identifies the problem.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-10 20:30:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	915537

Description Oded Ramraz 2013-01-01 15:51:43 UTC

Description of problem:

Wrong error when passing empty kwargs ( see additional information )

BTW I'm not sure that kwargs is the best parameter name , since CLI will be used also by non programmers users . 




Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

[RHEVM shell (connected)]# list quotas --datacenter-identifier 5849b030-626e-47cb-ad90-3ce782d831b3  --kwargs 

unknown error: 'NoneType' object has no attribute 'split'

[RHEVM shell (connected)]# list vms --kwargs 
unknown error: 'NoneType' object has no attribute 'split'

Comment 1 Oded Ramraz 2013-01-01 15:54:04 UTC

I would change this error as well: 

[RHEVM shell (connected)]# list vms  --kwargs "ssss"

unknown error: need more than 1 value to unpack

Comment 2 Michael Pasternak 2013-01-03 13:55:41 UTC

http://gerrit.ovirt.org/10620

Comment 3 Michael Pasternak 2013-01-06 11:38:16 UTC

new patch http://gerrit.ovirt.org/#/c/10678/

Comment 4 Oded Ramraz 2013-02-06 10:01:50 UTC

[RHEVM shell (connected)]# list quotas --datacenter-identifier e594779b-92ae-4c07-842c-eca3e427ea59 --kwargs 


error: --kwargs constraint cannot be empty.



Verified sf5

Comment 5 errata-xmlrpc 2013-06-10 20:30:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0890.html