Bug 891139

Summary:	Review Request: perl-Net-IDN-Encode - Internationalizing Domain Names in Applications (IDNA)
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <bochecha>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Net-IDN-Encode-2.201-2.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-21 04:56:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	892433

Description Mathieu Bridon 2013-01-02 00:57:27 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Net-IDN-Encode.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Net-IDN-Encode-2.003-1.fc18.src.rpm

Description:
This module provides an easy-to-use interface for encoding and decoding
Internationalized Domain Names (IDNs).

Fedora Account System Username: bochecha

Comment 1 Petr Šabata 2013-01-16 13:39:01 UTC

Taking the review.

Comment 2 Petr Šabata 2013-01-16 14:03:39 UTC

Issues:

Remove the executable bits on lib/Net/IDN/Encode.pm and lib/Net/IDN/Standards.pod.

The LICENCE and README files aren't in UTF8.  Convert them.

Add the following missing build deps:
perl(Exporter)
perl(Carp)
perl(Unicode::Normalize)
perl(XSLoader) [optional]

XSLoader isn't picked up by the automatic dep generator so you should require it manually.  There's a pure perl fallback if it isn't present so it's up to you.

Comment 3 Mathieu Bridon 2013-01-17 08:18:33 UTC

Thanks for the comments Petr.

They should all be addressed with this new submission.

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Net-IDN-Encode.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Net-IDN-Encode-2.003-2.fc18.src.rpm

Comment 4 Petr Šabata 2013-01-17 15:45:23 UTC

All good now, approving.

Comment 5 Mathieu Bridon 2013-01-18 03:08:27 UTC

New Package SCM Request
=======================
Package Name: perl-Net-IDN-Encode
Short Description: Internationalizing Domain Names in Applications (IDNA)
Owners: bochecha
Branches: devel
InitialCC: perl-sig

Comment 6 Gwyn Ciesla 2013-01-18 11:54:51 UTC

Git done (by process-git-requests).

Comment 7 Mathieu Bridon 2013-01-21 04:56:00 UTC

Thanks for the review Petr, and thank you Jon for the Git processing.

Package built in Rawhide, closing.

Comment 8 David Dick 2014-11-26 10:37:52 UTC

Hi Mathieu/Emmanuel,

I would like this package built for EPEL6 and EPEL7. I am happy to take responsibility for this if you don't want to.

Comment 9 David Dick 2014-12-13 11:09:20 UTC

Owner has not responded.

Package Change Request
======================
Package Name: perl-Net-IDN-Encode
New Branches: el6 epel7
Owners: ddick
InitialCC: perl-sig

Comment 10 Gwyn Ciesla 2014-12-15 13:18:55 UTC

Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-12-16 09:40:18 UTC

perl-Net-IDN-Encode-2.201-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Net-IDN-Encode-2.201-2.el6

Comment 12 Fedora Update System 2014-12-16 20:03:07 UTC

perl-Net-IDN-Encode-2.201-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-Net-IDN-Encode-2.201-2.el7

Comment 13 Fedora Update System 2015-01-14 16:29:14 UTC

perl-Net-IDN-Encode-2.201-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 14 Fedora Update System 2015-01-14 16:29:47 UTC

perl-Net-IDN-Encode-2.201-2.el6 has been pushed to the Fedora EPEL 6 stable repository.