Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-1.fc18.noarch.rpm Description: A tool for parsing domain names. This module makes use of the data provided by the Public Suffix List (http://publicsuffix.org/list/) to parse tlds. Fedora Account System Username: bochecha
This requires a few other packages for which I have submitted reviews: - perl-Net-IDN-Encode: bug 891139 - perl-Regexp-Assemble-Compressed: bug 891152 - perl-Test-Routine: bug 891165 - perl-Net-IDN-Nameprep: bug 891873 - perl-Perl6-Export-Attrs: bug 892423 Setting the "Depends On:" field accordingly.
Here's a new package which fixes the issues that the two Petrs have been asking me to fix in my recent submissions, over and over and over and over and... Thank you Petr and Petr. Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.noarch.rpm
(In reply to comment #2) > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. > noarch.rpm Correct link: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.src.rpm
Missing BRs: perl(base) from various sources perl(lib) from various sources perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3 perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9 I suppose changing "tlds" to "TLDs" in the description would nice. perl_default_filter is not necessary here. The rest looks okay to me.
(In reply to comment #3) > (In reply to comment #2) > > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. > > noarch.rpm > > Correct link: > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. > src.rpm Sorry about that. (In reply to comment #4) > Missing BRs: > perl(base) from various sources > perl(lib) from various sources > perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3 > perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9 Thanks, fixed. > I suppose changing "tlds" to "TLDs" in the description would nice. Agreed, fixed. > perl_default_filter is not necessary here. But does it cause any trouble? If not, I'd rather keep it there, so that I don't forget to add it if it eventually becomes necessary in the future. After all, it is a very good thing to have for many Perl packages... ---- Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-3.fc19.src.rpm
(In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #2) > > > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. > > > noarch.rpm > > > > Correct link: > > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. > > src.rpm > > Sorry about that. No worries. > (In reply to comment #4) > > Missing BRs: > > perl(base) from various sources > > perl(lib) from various sources > > perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3 > > perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9 > > Thanks, fixed. Ack. > > I suppose changing "tlds" to "TLDs" in the description would nice. > > Agreed, fixed. Ack. > > perl_default_filter is not necessary here. > > But does it cause any trouble? Nope, it does not. > If not, I'd rather keep it there, so that I don't forget to add it if it > eventually becomes necessary in the future. > > After all, it is a very good thing to have for many Perl packages... > > ---- > > Spec URL: > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec > SRPM URL: > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-3.fc19. > src.rpm Approving.
Thanks for the review Petr! New Package SCM Request ======================= Package Name: perl-ParseUtil-Domain Short Description: Utility for parsing a domain name into its components Owners: bochecha Branches: devel InitialCC: perl-sig
Git done (by process-git-requests).
Thanks Jon for the Git process. Package built in Rawhide, closing.