Bug 891165
Summary: | Review Request: perl-Test-Routine - Composable units of assertion | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mathieu Bridon <bochecha> |
Component: | Package Review | Assignee: | Petr Šabata <psabata> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, psabata |
Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-01-21 03:16:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 892433 |
Description
Mathieu Bridon
2013-01-02 05:49:14 UTC
Taking the review. Issues: Missing buildtime dependencies: perl(Carp) perl(Class::MOP) perl(Moose) perl(Moose::Meta::Class) perl(Moose::Role) perl(Moose::Util) perl(Moose::Util::TypeConstraints) perl(MooseX::Role::Parameterized) perl(namespace::clean) perl(Params::Util) perl(Scalar::Util) perl(Sub::Exporter) perl(Sub::Exporter::Util) They're all used during the test phase. Besides those, there's nothing to complain about :) Thanks Petr. I have a feeling that I'm often making the same mistake. :P Here is the new submission. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Routine.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Routine-0.015-2.fc18.src.rpm (In reply to comment #3) > I have a feeling that I'm often making the same mistake. :P I'm sure you won't in the future :) All issues addressed, approving. New Package SCM Request ======================= Package Name: perl-Test-Routine Short Description: Composable units of assertion Owners: bochecha Branches: devel InitialCC: perl-sig Git done (by process-git-requests). Thanks for the review Petr, and thank you Jon for the Git processing. Package is built in Rawhide, closing. |