Bug 891210

Summary: nodejs-nopt - Node.js option parsing
Product: [Fedora] Fedora Reporter: T.C. Hollingsworth <tchollingsworth>
Component: Package ReviewAssignee: Miro Hrončok <mhroncok>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mhroncok, misc, notting, package-review
Target Milestone: ---Flags: mhroncok: fedora‑review+
limburgher: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-15 04:30:58 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 891176    
Bug Blocks: 891171, 891175, 891212, 894724    

Description T.C. Hollingsworth 2013-01-02 03:42:59 EST
Spec: http://patches.fedorapeople.org/npm/nodejs-nopt.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-nopt-2.0.0-1.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4831038
FAS username: patches

An option parsing library for Node.js and its package manager (npm).

This package is part of the npm stack and a future F19 Feature for Node.js.

This package may depend on other packages in the npm stack that aren't explicitly
listed as dependencies of this bug.  For more information, see bug 891171.

Please use nodejs-0.6.5-3 or later when building or using this package.
Comment 1 T.C. Hollingsworth 2013-01-10 02:43:45 EST
Updated with empty %build sections and other issues found in various reviews.

Spec: http://patches.fedorapeople.org/npm/nodejs-nopt.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-nopt-2.0.0-2.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854346
Comment 2 Miro Hrončok 2013-01-10 13:11:02 EST
Description and Summary OK.

MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.

$ rpmlint ../SRPMS/nodejs-nopt-2.0.0-2.fc18.src.rpm ../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm
nodejs-nopt.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nopt.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-nopt.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm
nodejs-nopt.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nopt.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-nopt.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm
nodejs-nopt.noarch: W: only-non-binary-in-usr-lib
nodejs-nopt.noarch: W: dangling-relative-symlink /usr/bin/nopt ../node_modules/nopt/bin/nopt.js
nodejs-nopt.noarch: W: dangling-symlink /usr/lib/node_modules/nopt/node_modules/abbrev /usr/lib/node_modules/abbrev
nodejs-nopt.noarch: W: no-manual-page-for-binary nopt
2 packages and 0 specfiles checked; 0 errors, 10 warnings.

FIX: The symlink goes to /usr/node_modules/nopt/bin/nopt.js, should go to /usr/lib/node_modules/nopt/bin/nopt.js
TODO: If you think it is helpful, work with upstream to add the manpage

All others are false positive.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.

Checked in LICENSE, MIT. OK

MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL.

$ sha256sum ../SOURCES/nopt-2.0.0.tgz 
112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5  ../SOURCES/nopt-2.0.0.tgz
$ spectool -g nodejs-nopt.spec 
Getting http://registry.npmjs.org/nopt/-/nopt-2.0.0.tgz to ./nopt-2.0.0.tgz
$ sha256sum nopt-2.0.0.tgz 
112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5  nopt-2.0.0.tgz


MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK
MUST: Permissions on files must be set properly.

$ rpm -q -lv -p ../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm 
lrwxrwxrwx    1 root    root                       32 led 10 19:01 /usr/bin/nopt -> ../node_modules/nopt/bin/nopt.js
drwxr-xr-x    2 root    root                        0 led 10 19:01 /usr/lib/node_modules/nopt
drwxr-xr-x    2 root    root                        0 led 10 19:01 /usr/lib/node_modules/nopt/bin
-rwxr-xr-x    1 root    root                     1277 čec  6  2011 /usr/lib/node_modules/nopt/bin/nopt.js
drwxr-xr-x    2 root    root                        0 led 10 19:01 /usr/lib/node_modules/nopt/lib
-rw-r--r--    1 root    root                    15520 čec 24 00:34 /usr/lib/node_modules/nopt/lib/nopt.js
drwxr-xr-x    2 root    root                        0 led 10 19:01 /usr/lib/node_modules/nopt/node_modules
lrwxrwxrwx    1 root    root                       28 led 10 19:01 /usr/lib/node_modules/nopt/node_modules/abbrev -> /usr/lib/node_modules/abbrev
-rw-r--r--    1 root    root                      499 čec 24 00:36 /usr/lib/node_modules/nopt/package.json
drwxr-xr-x    2 root    root                        0 led 10 19:01 /usr/share/doc/nodejs-nopt-2.0.0
-rw-r--r--    1 root    root                     1092 kvě 13  2011 /usr/share/doc/nodejs-nopt-2.0.0/LICENSE
-rw-r--r--    1 root    root                     7610 říj 14  2011 /usr/share/doc/nodejs-nopt-2.0.0/README.md
drwxr-xr-x    2 root    root                        0 led 10 19:01 /usr/share/doc/nodejs-nopt-2.0.0/examples
-rwxr-xr-x    1 root    root                     1032 bře 31  2011 /usr/share/doc/nodejs-nopt-2.0.0/examples/my-program.js


MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK
MUST: Packages must not own files or directories already owned by other packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK
SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. As mentioned above.

NEEDSWORK: Basically, correct the symlink.
Comment 4 Miro Hrončok 2013-01-13 13:44:11 EST
Comment 5 T.C. Hollingsworth 2013-01-13 16:36:41 EST
New Package SCM Request
Package Name: nodejs-nopt
Short Description: Node.js option parsing
Owners: patches
Branches: f18 el6
Comment 6 Gwyn Ciesla 2013-01-14 07:09:22 EST
Git done (by process-git-requests).
Comment 7 Fedora Update System 2013-04-05 19:15:47 EDT
node-gyp-0.9.1-2.fc18, nodejs-async-0.2.6-1.fc18, nodejs-chmodr-0.1.0-2.fc18, nodejs-fstream-npm-0.1.4-1.fc18, nodejs-glob-3.1.21-1.fc18, nodejs-minimatch-0.2.11-1.fc18, nodejs-mkdirp-0.3.5-1.fc18, nodejs-npm-registry-client-0.2.18-2.fc18, nodejs-read-package-json-0.2.2-1.fc18, nodejs-request-2.14.0-1.fc18, nodejs-semver-1.1.4-1.fc18, npm-1.2.14-2.fc18, nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18, nodejs-inherits-1.0.0-6.fc18, nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18, nodejs-retry-0.6.0-2.fc18, nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18, nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18, nodejs-init-package-json-0.0.7-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18, nodejs-proto-list-1.2.2-2.fc18, nodejs-which-1.0.5-4.fc18, nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18, nodejs-once-1.1.1-2.fc18, nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18, nodejs-block-stream-0.0.6-4.fc18, nodejs-npmlog-0.0.2-2.fc18, nodejs-opener-1.3.0-4.fc18, nodejs-tobi-cookie-0.3.2-2.fc18, nodejs-promzard-0.2.0-3.fc18, nodejs-combined-stream-0.0.4-1.fc18, nodejs-config-chain-1.1.5-1.fc18, nodejs-fstream-0.1.22-1.fc18, nodejs-fstream-ignore-0.0.6-1.fc18, nodejs-graceful-fs-1.2.0-1.fc18, nodejs-ini-1.1.0-1.fc18, nodejs-lockfile-0.3.0-1.fc18, nodejs-lru-cache-2.2.2-1.fc18, nodejs-mime-1.2.9-1.fc18, nodejs-nopt-2.1.1-1.fc18, nodejs-npmconf-0.0.23-1.fc18, nodejs-read-installed-0.1.1-1.fc18, nodejs-rimraf-2.1.4-1.fc18, nodejs-tar-0.1.16-1.fc18, nodejs-form-data-0.0.7-1.fc18 has been pushed to the Fedora 18 stable repository.