Bug 891312

Summary: Review Request: ldapdiff - Tool for incremental LDAP directory updates based on ldif files
Product: [Fedora] Fedora Reporter: Nicolas Chauvet (kwizart) <kwizart>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review
Target Milestone: ---Flags: mtasaka: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-03 16:31:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nicolas Chauvet (kwizart) 2013-01-02 14:54:53 UTC 
Spec URL: http://kwizart.fedorapeople.org/review/ldapdiff.spec
SRPM URL: http://kwizart.fedorapeople.org/review/ldapdiff-1.4.1-1.fc17.src.rpm
Description:  Tool for incremental LDAP directory updates based on ldif files
Fedora Account System Username: kwizart


Koji rawhide scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4832975

rpmlint (from el6):
$ rpmlint ldapdiff-1.4.1-1.fc17.src.rpm 
ldapdiff.src:35: E: files-attr-not-set
ldapdiff.src:36: E: files-attr-not-set
ldapdiff.src:37: E: files-attr-not-set
ldapdiff.src:38: E: files-attr-not-set
ldapdiff.src:39: E: files-attr-not-set
ldapdiff.src:40: E: files-attr-not-set
ldapdiff.src:41: E: files-attr-not-set
ldapdiff.src: W: no-cleaning-of-buildroot %clean
ldapdiff.src: W: no-buildroot-tag
ldapdiff.src: W: no-%clean-section

Should be safe to ignore
Comment 1 Mamoru TASAKA 2013-01-02 15:05:42 UTC 
Taking this. I would appreciate it if you would review my review request bug 875352.
Comment 2 Nicolas Chauvet (kwizart) 2013-01-02 15:37:19 UTC 
(In reply to comment #1)
> Taking this. I would appreciate it if you would review my review request bug
> 875352.
Sure, I will handle when back to home.
Comment 3 Mamoru TASAKA 2013-01-02 16:13:36 UTC 
Well, while I have not checked in detail how ldapdiff utility 
works, packaging for this software seems simple and reviewing
for this srpm is straightforward.

Some minor issues (not blockers)
* Cleaning %buildroot at %install
  https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag
  - "rm -rf $RPM_BUILD_ROOT"
    at the beginning of %install is no longer needed
    because rpmbuild will always clean up $RPM_BUILD_ROOT
    at the beginning of %install.

Other things are okay
- spec file clean
- tarball matches with the upstream
- build clean
- built binary rpm clean
- can be installed
- at least ldapdiff -v works

----------------------------------------------------------
   This package (ldapdiff) is APPROVED by mtasaka
----------------------------------------------------------
Comment 4 Nicolas Chauvet (kwizart) 2013-01-02 23:28:25 UTC 
New Package SCM Request
=======================
Package Name: ldapdiff
Short Description: Tool for incremental LDAP directory updates based on ldif files
Owners: kwizart
Branches: f17 f18 el6 el5
InitialCC:
Comment 5 Gwyn Ciesla 2013-01-03 15:21:35 UTC 
Git done (by process-git-requests).
Comment 6 Nicolas Chauvet (kwizart) 2013-01-03 16:31:49 UTC 
imported and built, thx!
Comment 7 Mamoru TASAKA 2013-01-03 16:47:15 UTC 
(Just unsetting fedora-cvs flag: no longer needed)