Spec URL: http://kwizart.fedorapeople.org/review/ldapdiff.spec SRPM URL: http://kwizart.fedorapeople.org/review/ldapdiff-1.4.1-1.fc17.src.rpm Description: Tool for incremental LDAP directory updates based on ldif files Fedora Account System Username: kwizart Koji rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4832975 rpmlint (from el6): $ rpmlint ldapdiff-1.4.1-1.fc17.src.rpm ldapdiff.src:35: E: files-attr-not-set ldapdiff.src:36: E: files-attr-not-set ldapdiff.src:37: E: files-attr-not-set ldapdiff.src:38: E: files-attr-not-set ldapdiff.src:39: E: files-attr-not-set ldapdiff.src:40: E: files-attr-not-set ldapdiff.src:41: E: files-attr-not-set ldapdiff.src: W: no-cleaning-of-buildroot %clean ldapdiff.src: W: no-buildroot-tag ldapdiff.src: W: no-%clean-section Should be safe to ignore
Taking this. I would appreciate it if you would review my review request bug 875352.
(In reply to comment #1) > Taking this. I would appreciate it if you would review my review request bug > 875352. Sure, I will handle when back to home.
Well, while I have not checked in detail how ldapdiff utility works, packaging for this software seems simple and reviewing for this srpm is straightforward. Some minor issues (not blockers) * Cleaning %buildroot at %install https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag - "rm -rf $RPM_BUILD_ROOT" at the beginning of %install is no longer needed because rpmbuild will always clean up $RPM_BUILD_ROOT at the beginning of %install. Other things are okay - spec file clean - tarball matches with the upstream - build clean - built binary rpm clean - can be installed - at least ldapdiff -v works ---------------------------------------------------------- This package (ldapdiff) is APPROVED by mtasaka ----------------------------------------------------------
New Package SCM Request ======================= Package Name: ldapdiff Short Description: Tool for incremental LDAP directory updates based on ldif files Owners: kwizart Branches: f17 f18 el6 el5 InitialCC:
Git done (by process-git-requests).
imported and built, thx!
(Just unsetting fedora-cvs flag: no longer needed)