Bug 891679
| Summary: | minor spec file fixes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Winship <danw> | ||||
| Component: | libproxy | Assignee: | Nicolas Chauvet (kwizart) <kwizart> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | kwizart, nathaniel | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-01-05 14:53:23 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
OK, but why to remove the gecko dependency. We cannot expect to use libproxy built with a version of xulrunner more recent than what is installed on the user system. libproxy-mozjs is not built against xulrunner any more, it's built against the split-out js-1.8.5 package, and only depends on libmozjs185.so.1.0, which is ABI-stable, so that dependency is handled fine by RPM on its own.
Also, gecko_version is no longer defined by the spec file, so currently we end up with the string getting inserted literally into the dependencies:
danw@laptop:~> rpm -qR libproxy-mozjs | grep gecko
gecko-libs >= %{gecko_version}
which RPM seems to ignore since it's not numeric (but one of the RHEL lint tools complains about).
(Sorry, that was actually explained somewhat in the commit message, which you'll see if you click on the "spec file patch" link under "Attachments", but not if you click on "attachment 672112 [details]", because redhat bugzilla is configured annoyingly...)
Thx, your patch was applied in all branches. |
Created attachment 672112 [details] spec file patch