Bug 891679 - minor spec file fixes
Summary: minor spec file fixes
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libproxy
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nicolas Chauvet (kwizart)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-03 16:32 UTC by Dan Winship
Modified: 2013-01-05 14:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-01-05 14:53:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
spec file patch (2.54 KB, patch)
2013-01-03 16:32 UTC, Dan Winship
no flags Details | Diff

Description Dan Winship 2013-01-03 16:32:19 UTC
Created attachment 672112 [details]
spec file patch

Comment 1 Nicolas Chauvet (kwizart) 2013-01-04 13:31:49 UTC
OK, but why to remove the gecko dependency.
We cannot expect to use libproxy built with a version of xulrunner more recent than what is installed on the user system.

Comment 2 Dan Winship 2013-01-04 15:14:29 UTC
libproxy-mozjs is not built against xulrunner any more, it's built against the split-out js-1.8.5 package, and only depends on libmozjs185.so.1.0, which is ABI-stable, so that dependency is handled fine by RPM on its own.

Also, gecko_version is no longer defined by the spec file, so currently we end up with the string getting inserted literally into the dependencies:

  danw@laptop:~> rpm -qR libproxy-mozjs | grep gecko
  gecko-libs >= %{gecko_version}

which RPM seems to ignore since it's not numeric (but one of the RHEL lint tools complains about).

Comment 3 Dan Winship 2013-01-04 15:16:19 UTC
(Sorry, that was actually explained somewhat in the commit message, which you'll see if you click on the "spec file patch" link under "Attachments", but not if you click on "attachment 672112 [details]", because redhat bugzilla is configured annoyingly...)

Comment 4 Nicolas Chauvet (kwizart) 2013-01-05 14:53:23 UTC
Thx, your patch was applied in all branches.


Note You need to log in before you can comment on or make changes to this bug.