Bug 891999 (lua-penlight)
| Summary: | Review Request: lua-penlight - Penlight Lua Libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Moschny <thomas.moschny> |
| Component: | Package Review | Assignee: | Stanislav Ochotnicky <sochotni> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, sochotni |
| Target Milestone: | --- | Flags: | sochotni:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-01-23 01:44:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 891996 | ||
|
Description
Thomas Moschny
2013-01-04 19:41:31 UTC
Reset the fedora-review flag, somehow I misread the guidelines. I will not post whole output of fedora-review since it's unnecessary, the package is mostly good. Three points remain:
1. Have you tried running tests from "tests" directory?
2. It would be nice to package examples as a separate subpackage too.
3. There are also two typos, one discovered by rpmlint:
lua-penlight.noarch: W: spelling-error %description -l en_US focussing -> focusing, focus sing, focus-sing
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
and another in comment:
# there's a circlular (build) dependency with lua-ldoc
^
Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-2.a.fc17.src.rpm %changelog * Wed Jan 9 2013 Thomas Moschny <..> - 1.0.3-2.a - Fix typos. - Package examples as a separate subpackage. - Run tests. Package now fails to build (during tests): lua: run.lua:3: module 'lfs' not found Seems like tests should only be enabled when docs are built as well Sorry, forgot one BR. Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-3.a.fc17.src.rpm %changelog * Thu Jan 10 2013 Thomas Moschny <..> - 1.0.3-3.a - Add BR on lua-filesystem (needed when running the tests). - Fix line-endings for the examples. Very nice, thanks for taking the issues up with upstream as well. APPROVED Thanks again for the review! New Package SCM Request ======================= Package Name: lua-penlight Short Description: Penlight Lua Libraries Owners: thm Branches: f16 f17 f18 InitialCC: Git done (by process-git-requests). lua-penlight-1.0.3-3.a.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc18 lua-penlight-1.0.3-3.a.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc16 lua-penlight-1.0.3-3.a.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc17 lua-penlight-1.0.3-3.a.fc18 has been pushed to the Fedora 18 testing repository. lua-penlight-1.0.3-3.a.fc18 has been pushed to the Fedora 18 stable repository. lua-penlight-1.0.3-3.a.fc16 has been pushed to the Fedora 16 stable repository. lua-penlight-1.0.3-3.a.fc17 has been pushed to the Fedora 17 stable repository. |