Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-1.a.fc17.src.rpm Description: Penlight brings together a set of generally useful pure Lua modules, focussing on input data handling (such as reading configuration files), functional programming (such as map, reduce, placeholder expressions,etc), and OS path management. Much of the functionality is inspired by the Python standard libraries. Fedora Account System Username: thm
Reset the fedora-review flag, somehow I misread the guidelines.
I will not post whole output of fedora-review since it's unnecessary, the package is mostly good. Three points remain: 1. Have you tried running tests from "tests" directory? 2. It would be nice to package examples as a separate subpackage too. 3. There are also two typos, one discovered by rpmlint: lua-penlight.noarch: W: spelling-error %description -l en_US focussing -> focusing, focus sing, focus-sing 1 packages and 0 specfiles checked; 0 errors, 1 warnings. and another in comment: # there's a circlular (build) dependency with lua-ldoc ^
Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-2.a.fc17.src.rpm %changelog * Wed Jan 9 2013 Thomas Moschny <..> - 1.0.3-2.a - Fix typos. - Package examples as a separate subpackage. - Run tests.
Package now fails to build (during tests): lua: run.lua:3: module 'lfs' not found Seems like tests should only be enabled when docs are built as well
Sorry, forgot one BR. Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-3.a.fc17.src.rpm %changelog * Thu Jan 10 2013 Thomas Moschny <..> - 1.0.3-3.a - Add BR on lua-filesystem (needed when running the tests). - Fix line-endings for the examples.
Very nice, thanks for taking the issues up with upstream as well. APPROVED
Thanks again for the review! New Package SCM Request ======================= Package Name: lua-penlight Short Description: Penlight Lua Libraries Owners: thm Branches: f16 f17 f18 InitialCC:
Git done (by process-git-requests).
lua-penlight-1.0.3-3.a.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc18
lua-penlight-1.0.3-3.a.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc16
lua-penlight-1.0.3-3.a.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc17
lua-penlight-1.0.3-3.a.fc18 has been pushed to the Fedora 18 testing repository.
lua-penlight-1.0.3-3.a.fc18 has been pushed to the Fedora 18 stable repository.
lua-penlight-1.0.3-3.a.fc16 has been pushed to the Fedora 16 stable repository.
lua-penlight-1.0.3-3.a.fc17 has been pushed to the Fedora 17 stable repository.