Bug 895810
| Summary: | Review Request: glassfish-legal - Legal License for glassfish code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glassfish-legal-1.1-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-31 04:31:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 870995 | ||
| Bug Blocks: | 889303, 947509 | ||
|
Description
gil cattaneo
2013-01-16 03:21:21 UTC
I'm not going to get too meta here and discuss the viability of trying to describe the license of a package which just contains license files. That might be fun some other time though. :) = Review = Good: - rpmlint checks return: glassfish-legal.src: W: invalid-url Source0: glassfish-legal-1.1-src-svn.tar.gz Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (manual diff due to SVN checkout) - package compiles on f19 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - nothing in %doc affects runtime - no need for .desktop file APPROVED. Thanks for the review New Package SCM Request ======================= Package Name: glassfish-legal Short Description: Legal License for glassfish code Owners: gil Branches: f18 f19 InitialCC: java-sig Git done (by process-git-requests). glassfish-legal-1.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/glassfish-legal-1.1-1.fc18 glassfish-legal-1.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glassfish-legal-1.1-1.fc19 glassfish-legal-1.1-1.fc19 has been pushed to the Fedora 19 testing repository. glassfish-legal-1.1-1.fc18 has been pushed to the Fedora 18 stable repository. glassfish-legal-1.1-1.fc19 has been pushed to the Fedora 19 stable repository. |