Bug 895810 - Review Request: glassfish-legal - Legal License for glassfish code
Review Request: glassfish-legal - Legal License for glassfish code
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tom "spot" Callaway
Fedora Extras Quality Assurance
Depends On: 870995
Blocks: 889303 947509
  Show dependency treegraph
Reported: 2013-01-15 22:21 EST by gil cattaneo
Modified: 2013-06-03 15:29 EDT (History)
3 users (show)

See Also:
Fixed In Version: glassfish-legal-1.1-1.fc19
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-05-31 00:31:23 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tcallawa: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description gil cattaneo 2013-01-15 22:21:21 EST
Spec URL: http://gil.fedorapeople.org/glassfish-legal.spec
SRPM URL: http://gil.fedorapeople.org/glassfish-legal-1.1-1.fc18.src.rpm
An archive which contains license files for glassfish code.
Fedora Account System Username: gil
Comment 1 Tom "spot" Callaway 2013-05-16 10:47:42 EDT
I'm not going to get too meta here and discuss the viability of trying to describe the license of a package which just contains license files. That might be fun some other time though. :)

= Review =


- rpmlint checks return:

glassfish-legal.src: W: invalid-url Source0: glassfish-legal-1.1-src-svn.tar.gz

Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff due to SVN checkout)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file

Comment 2 gil cattaneo 2013-05-16 10:52:26 EDT
Thanks for the review

New Package SCM Request
Package Name: glassfish-legal
Short Description: Legal License for glassfish code
Owners: gil
Branches: f18 f19
InitialCC: java-sig
Comment 3 Gwyn Ciesla 2013-05-16 11:29:54 EDT
Git done (by process-git-requests).
Comment 4 Fedora Update System 2013-05-21 22:32:43 EDT
glassfish-legal-1.1-1.fc18 has been submitted as an update for Fedora 18.
Comment 5 Fedora Update System 2013-05-21 22:43:09 EDT
glassfish-legal-1.1-1.fc19 has been submitted as an update for Fedora 19.
Comment 6 Fedora Update System 2013-05-22 18:36:32 EDT
glassfish-legal-1.1-1.fc19 has been pushed to the Fedora 19 testing repository.
Comment 7 Fedora Update System 2013-05-31 00:31:23 EDT
glassfish-legal-1.1-1.fc18 has been pushed to the Fedora 18 stable repository.
Comment 8 Fedora Update System 2013-05-31 23:17:17 EDT
glassfish-legal-1.1-1.fc19 has been pushed to the Fedora 19 stable repository.

Note You need to log in before you can comment on or make changes to this bug.