Bug 901419
| Summary: | Review Request: perl-Lingua-Identify - Language identification | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mathieu Bridon <mathieu> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-08 07:10:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 901387, 901412, 907309 | ||
| Bug Blocks: | |||
|
Description
Mathieu Bridon
2013-01-18 07:17:08 UTC
This package requires two other packages which I have submitted to Fedora: - Text::Affixes (bug 901387) - Text::Ngram (bug 901412) Setting bugs dependencies accordingly. As a tribute to the two Petrs, here is a new package, fixing some of the issues they have commonly asked me to fix in my recent submissions. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Lingua-Identify.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Lingua-Identify-0.51-2.fc18.src.rpm (In reply to comment #2) > As a tribute to the two Petrs, here is a new package, fixing some of the > issues they have commonly asked me to fix in my recent submissions. :)) Taking the review. Ok, so I've looked at your new package and have some "bad news" for you :) You're missing a BR, perl(Exporter) -- this is pulled in through "use base" on lib/Lingua/Identify.pm:8. On the other hand, you don't have to list the dependencies of the make-lingua-identify-language (perl(locale) and perl(POSIX)) as it's not tested, even though upstream probably wanted to (given the fourth test filename). I've created a ticket for it, RT#83071 [1]. You can also just patch the test and keep your deps in place. If you decide to do this instead, also add perl(Text::ExtractWords) to your list. [1] https://rt.cpan.org/Public/Bug/Display.html?id=83071 (In reply to comment #4) > Ok, so I've looked at your new package and have some "bad news" for you :) > > You're missing a BR, perl(Exporter) -- this is pulled in through "use base" > on lib/Lingua/Identify.pm:8. Added. > On the other hand, you don't have to list the dependencies of the > make-lingua-identify-language (perl(locale) and perl(POSIX)) as it's not > tested, even though upstream probably wanted to (given the fourth test > filename). > I've created a ticket for it, RT#83071 [1]. Thanks, I had completely missed that. > You can also just patch the test and keep your deps in place. If you decide > to do this instead, also add perl(Text::ExtractWords) to your list. Unfortunately, Text::ExtractWords is not in Fedora. :( https://bugzilla.redhat.com/show_bug.cgi?id=907309 --- Spec URL: http://bochecha.fedorapeople.org/packages/perl-Lingua-Identify.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Lingua-Identify-0.51-3.fc19.src.rpm Ok, looks good now. Text::ExtractWords is in Rawhide now too :) Thanks for the review Petr! New Package SCM Request ======================= Package Name: perl-Lingua-Identify Short Description: Language identification Owners: bochecha Branches: devel InitialCC: perl-sig Git done (by process-git-requests). Thanks for the Git process Jon. Package built in Rawhide, closing. |