Spec URL: http://bochecha.fedorapeople.org/packages/perl-Text-Ngram,spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Text-Ngram-0.14-1.fc18.src.rpm Description: n-Gram analysis is a field in textual analysis which uses sliding window character sequences in order to aid topic analysis, language determination and so on. The n-gram spectrum of a document can be used to compare and filter documents in multiple languages, prepare word prediction networks, and perform spelling correction. Fedora Account System Username: bochecha
I'll assume spec URL is <http://bochecha.fedorapeople.org/packages/perl-Text-Ngram.spec>. URL and Source0 are usable. Ok. Source file is original (SHA-256: be828634315e76181bdfdfc4193515d81fd6ceb69463c135ff856d7db7b4fb48). Ok. Summary verified from lib/Text/Ngram.pm. Ok. Description verified from lib/Text/Ngram.pm. Ok. License verified from lib/Text/Ngram.pm, ppport.h. Ok. TODO: You can replace %{__perl} macro with plain perl command. TODO: Replace PERL_INSTALL_ROOT variable with DESTDIR in %install section. XS code presents, architecture specific BuildArch is Ok. TODO: Build-require `perl(Exporter)' (lib/Text/Ngram.pm:7). TODO: Build-require `perl(XSLoader)' (lib/Text/Ngram.pm:53). TODO: Add version constraint `>= 1.14' to `perl(Test::Pod)' BuildRequires (t/pod.t:4). TODO: Add version constraint `>= 1.04' to `perl(Test::Pod::Coverage)' BuildRequires (t/pod-coverage.t:4). All tests pass. Ok. $ rpmlint perl-Text-Ngram.spec ../SRPMS/perl-Text-Ngram-0.14-1.fc19.src.rpm ../RPMS/x86_64/perl-Text-Ngram-* 3 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Text-Ngram-0.14-1.fc19.x86_64.rpm drwxr-xr-x 2 root root 0 Jan 23 11:21 /usr/lib64/perl5/vendor_perl/Text -rw-r--r-- 1 root root 6260 Jan 25 2012 /usr/lib64/perl5/vendor_perl/Text/Ngram.pm drwxr-xr-x 2 root root 0 Jan 23 11:21 /usr/lib64/perl5/vendor_perl/auto/Text drwxr-xr-x 2 root root 0 Jan 23 11:21 /usr/lib64/perl5/vendor_perl/auto/Text/Ngram -rwxr-xr-x 1 root root 11184 Jan 23 11:21 /usr/lib64/perl5/vendor_perl/auto/Text/Ngram/Ngram.so drwxr-xr-x 2 root root 0 Jan 23 11:21 /usr/share/doc/perl-Text-Ngram-0.14 -rw-r--r-- 1 root root 136 Jan 16 2012 /usr/share/doc/perl-Text-Ngram-0.14/CREDITS -rw-r--r-- 1 root root 1986 Jan 25 2012 /usr/share/doc/perl-Text-Ngram-0.14/Changes -rw-r--r-- 1 root root 4323 Jan 16 2012 /usr/share/doc/perl-Text-Ngram-0.14/README -rw-r--r-- 1 root root 3823 Jan 23 11:21 /usr/share/man/man3/Text::Ngram.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Text-Ngram-0.14-1.fc19.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl >= 0:5.008008 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Text-Ngram-0.14-1.fc19.x86_64.rpm | sort | uniq -c 1 perl(Text::Ngram) = 0.14 1 perl-Text-Ngram = 0.14-1.fc19 1 perl-Text-Ngram(x86-64) = 0.14-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Text-Ngram-0.14-1.fc19.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4896209). ??? Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items when building this package. Resolution: Package APPROVED.
(In reply to comment #1) > I'll assume spec URL is > <http://bochecha.fedorapeople.org/packages/perl-Text-Ngram.spec>. Oh, right, sorry about that. :-/ > TODO: You can replace %{__perl} macro with plain perl command. Fixed. > TODO: Replace PERL_INSTALL_ROOT variable with DESTDIR in %install section. Ok. > TODO: Build-require `perl(Exporter)' (lib/Text/Ngram.pm:7). > TODO: Build-require `perl(XSLoader)' (lib/Text/Ngram.pm:53). Done. > TODO: Add version constraint `>= 1.14' to `perl(Test::Pod)' BuildRequires > (t/pod.t:4). > TODO: Add version constraint `>= 1.04' to `perl(Test::Pod::Coverage)' > BuildRequires (t/pod-coverage.t:4). Added. > Please consider fixing `TODO' items when building this package. For the record, here is the new package with the above items fixed. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Text-Ngram,spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Text-Ngram-0.14-2.fc19.src.rpm > Resolution: Package APPROVED. Thanks for the review Petr! New Package SCM Request ======================= Package Name: perl-Text-Ngram Short Description: Ngram analysis of text Owners: bochecha Branches: devel InitialCC: perl-sig
Git done (by process-git-requests).
Thank you Jon for the Git process. Package built in Rawhide, closing.