Bug 902239
| Summary: | small flaw in /usr/bin/dwm-start in rebuild() | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Haško <mhasko> |
| Component: | dwm | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 17 | CC: | psabata, pslavice |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-01 16:33:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This also affects Fedora 17. (In reply to comment #0) > a. User may wish to not use config.h file and instead keep his modified > configuration as a patch of config.def.h inside the ${patches} dir. > Therefore copying ${config} over ${builddir}/config.def.h would > effectively > rid user of his configuration. The user configuration should always reside in config.h; config.def.h is just upstream default and is only used if config.h is not present. Anyhow, the config file is now copied to config.h and before the patches are applied. Furthermore, the rebuild() function now checks for config file or the patches directory; having just one of those is sufficient. dwm-6.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/dwm-6.0-4.fc18 dwm-6.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/dwm-6.0-4.fc17 Package dwm-6.0-4.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing dwm-6.0-4.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-1217/dwm-6.0-4.fc17 then log in and leave karma (feedback). dwm-6.0-4.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. dwm-6.0-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |
There are two small problems with this piece of code: if [ -d ${patches} ]; then echo "${name}: Applying patches..." 1>&2 find ${patches} -type f -name '*.diff' -printf "patch -p1 < %p\n" | sh fi cp ${config} ${builddir}/config.def.h a. User may wish to not use config.h file and instead keep his modified configuration as a patch of config.def.h inside the ${patches} dir. Therefore copying ${config} over ${builddir}/config.def.h would effectively rid user of his configuration. b. The patches should be applied after user config file is copied. Version-Release number of selected component (if applicable): dwm-user-6.0-3.fc18.x86_64