Bug 902239 - small flaw in /usr/bin/dwm-start in rebuild()
Summary: small flaw in /usr/bin/dwm-start in rebuild()
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: dwm
Version: 17
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-21 08:36 UTC by Michal Haško
Modified: 2015-03-02 04:01 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-02-01 16:33:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michal Haško 2013-01-21 08:36:55 UTC
There are two small problems with this piece of code:

    if [ -d ${patches} ]; then
        echo "${name}: Applying patches..." 1>&2
        find ${patches} -type f -name '*.diff' -printf "patch -p1 < %p\n" | sh
    fi
    cp ${config} ${builddir}/config.def.h

a. User may wish to not use config.h file and instead keep his modified
   configuration as a patch of config.def.h inside the ${patches} dir.
   Therefore copying ${config} over ${builddir}/config.def.h would effectively
   rid user of his configuration.

b. The patches should be applied after user config file is copied.

Version-Release number of selected component (if applicable):
dwm-user-6.0-3.fc18.x86_64

Comment 1 Petr Šabata 2013-01-21 08:40:09 UTC
This also affects Fedora 17.

Comment 2 Petr Šabata 2013-01-21 09:47:41 UTC
(In reply to comment #0)
> a. User may wish to not use config.h file and instead keep his modified
>    configuration as a patch of config.def.h inside the ${patches} dir.
>    Therefore copying ${config} over ${builddir}/config.def.h would
> effectively
>    rid user of his configuration.

The user configuration should always reside in config.h; config.def.h is just upstream default and is only used if config.h is not present.

Anyhow, the config file is now copied to config.h and before the patches are applied.  Furthermore, the rebuild() function now checks for config file or the patches directory; having just one of those is sufficient.

Comment 3 Fedora Update System 2013-01-21 10:35:27 UTC
dwm-6.0-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/dwm-6.0-4.fc18

Comment 4 Fedora Update System 2013-01-21 10:36:17 UTC
dwm-6.0-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/dwm-6.0-4.fc17

Comment 5 Fedora Update System 2013-01-23 01:39:23 UTC
Package dwm-6.0-4.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing dwm-6.0-4.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-1217/dwm-6.0-4.fc17
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-02-01 16:33:21 UTC
dwm-6.0-4.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2013-02-01 16:35:48 UTC
dwm-6.0-4.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.