Bug 902363

Summary: Invalid property 'PortalPermissionSelector' or 'PagePermissionSelector' instead of 'Access Permission Setting'
Product: [JBoss] JBoss Enterprise Portal Platform 6 Reporter: Michal Vanco <mvanco>
Component: PortalAssignee: Boleslaw Dawidowicz <bdawidow>
Status: CLOSED CURRENTRELEASE QA Contact: vramik
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.0.0CC: bdawidow, epp-bugs, hfnukal, mvecera, theute, vramik
Target Milestone: CR01   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
An issue with missing i18n keys caused the PortalPermissionSelector and PagePermissionSelector i18n to be included instead of the translated UI text. Additionally, the icon was missing from the left of the translated string. The fix adds the two missing i18n keys using the #{UITabPane.title.UIListPermissionSelector} expression so that it was enough to add them into the file for locale 'en'. The .UITabSelector .FlatTabStyle .UIPermissionSelector24x24Icon rule was copied and renamed to match the expected class names PortalPermissionSelector24x24Icon and PagePermissionSelector24x24Icon. The forms now show internationalized texts and icons.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-16 08:55:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot 1
none
Screenshot 2 none

Description Michal Vanco 2013-01-21 13:27:27 UTC 
There is invalid property when setting permissions for portal/page.

This is caused by https://github.com/gatein/gatein-portal/commit/7a0935858c6d13c0267e1a5f4b945dca2331d003 (fix for GTNPORTAL-2753)

Version-Release number of selected component (if applicable):
JPP 6.0.0 ER05

How reproducible:
always

Steps to Reproduce:
1. sign in
2. create new portal or page and go to permission setting - invalid access permission tab
  
Actual results:
See attached screenshots

Expected results:
Access Permission Setting should be displayed
Comment 1 Michal Vanco 2013-01-21 13:28:11 UTC 
Created attachment 684285 [details]
Screenshot 1
Comment 2 Michal Vanco 2013-01-21 13:28:31 UTC 
Created attachment 684286 [details]
Screenshot 2
Comment 3 Michal Vanco 2013-01-21 13:31:31 UTC 
Issue is also present at GateIn 3.5.1.Final
Comment 4 Michal Vanco 2013-01-21 13:39:05 UTC 
This also affects missing icon at tab, right now there is a class PortalPermissionSelector24x24Icon - which doesn't exist. Expected class was UIListPermissionSelector24x24Icon
Comment 5 Peter Palaga 2013-01-21 16:46:29 UTC 
The named commit has apparently unexpected consequences in UITabSelector.gtmpl:

<div class="TabIcon ${uiChild.id}24x24Icon">
  <a class="Title"><%=_ctx.appRes("UITabPane.title." + uiChild.getId());%></a>
</div>

Is there a better fix then adding the missing 

  UITabPane.title.PortalPermissionSelector
  UITabPane.title.PagePermissionSelector

keys in webui_en.properties and other webui_*.* files? In this way, one would duplicate

  UITabPane.title.UIListPermissionSelector=Access Permission Setting

BTW. is Access Permission Settings in plural not better?

The missing icons can be fixed similarly through duplicating .UIListPermissionSelector24x24Icon in /component/web/resources/src/test/resources/Stylesheet.css or web/eXoResources/src/main/webapp/skin/DefaultSkin/skinIcons/24x24/Stylesheet.css
Comment 6 JBoss JIRA Server 2013-01-23 12:50:51 UTC 
Peter Palaga <ppalaga> made a comment on jira GTNPORTAL-2804

I have ensured that the issue does not occur in UICategoryForm, UIPortletForm and UIContainerForm. I was not able to spot any occurence of UIPermissionForm in the UI, so I could not check if it has the issue.

Only UIPortalForm and UIPageForm seem to be affected where the UIListPermissionSelector is placed in a UIFormInputSet.
Comment 7 JBoss JIRA Server 2013-01-23 14:05:29 UTC 
Peter Palaga <ppalaga> made a comment on jira GTNPORTAL-2804

The fix adds the two missing i18n keys using {{\#\{UITabPane.title.UIListPermissionSelector\}}} so it was enough to add them into the file for locale "en". Other locales can resolve the expression into the proper language specific value.

The fix also fixes the issue with missing icon. In this case the {{.UITabSelector .FlatTabStyle .UIPermissionSelector24x24Icon}} rule was simply copied and renamed to match the expected class names {{PortalPermissionSelector24x24Icon}} and {{PagePermissionSelector24x24Icon}}.
Comment 8 Peter Palaga 2013-01-23 14:58:34 UTC 
PR submitted to GateIn 3.5.x branch. https://github.com/gatein/gatein-portal/pull/319
Comment 9 Michal Vanco 2013-01-24 13:11:42 UTC 
*** Bug 902361 has been marked as a duplicate of this bug. ***
Comment 10 Thomas Heute 2013-01-29 12:39:37 UTC 
Assigning to Bolek, making sure it goes in GateIn 3.5.2
Comment 11 Thomas Heute 2013-01-30 12:42:03 UTC 
Fix will be in 3.5.2
Comment 12 vramik 2013-02-04 16:06:31 UTC 
Verified on gatein master (3.6.0.MO1-SNAPSHOT).
Comment 13 vramik 2013-02-12 15:21:54 UTC 
verified on jpp6.0.cr01
Comment 14 Thomas Heute 2013-03-04 10:40:26 UTC 
Doesn't require a release note, bug happened between 2 internal releases