There is invalid property when setting permissions for portal/page. This is caused by https://github.com/gatein/gatein-portal/commit/7a0935858c6d13c0267e1a5f4b945dca2331d003 (fix for GTNPORTAL-2753) Version-Release number of selected component (if applicable): JPP 6.0.0 ER05 How reproducible: always Steps to Reproduce: 1. sign in 2. create new portal or page and go to permission setting - invalid access permission tab Actual results: See attached screenshots Expected results: Access Permission Setting should be displayed
Created attachment 684285 [details] Screenshot 1
Created attachment 684286 [details] Screenshot 2
Issue is also present at GateIn 3.5.1.Final
This also affects missing icon at tab, right now there is a class PortalPermissionSelector24x24Icon - which doesn't exist. Expected class was UIListPermissionSelector24x24Icon
The named commit has apparently unexpected consequences in UITabSelector.gtmpl: <div class="TabIcon ${uiChild.id}24x24Icon"> <a class="Title"><%=_ctx.appRes("UITabPane.title." + uiChild.getId());%></a> </div> Is there a better fix then adding the missing UITabPane.title.PortalPermissionSelector UITabPane.title.PagePermissionSelector keys in webui_en.properties and other webui_*.* files? In this way, one would duplicate UITabPane.title.UIListPermissionSelector=Access Permission Setting BTW. is Access Permission Settings in plural not better? The missing icons can be fixed similarly through duplicating .UIListPermissionSelector24x24Icon in /component/web/resources/src/test/resources/Stylesheet.css or web/eXoResources/src/main/webapp/skin/DefaultSkin/skinIcons/24x24/Stylesheet.css
Peter Palaga <ppalaga> made a comment on jira GTNPORTAL-2804 I have ensured that the issue does not occur in UICategoryForm, UIPortletForm and UIContainerForm. I was not able to spot any occurence of UIPermissionForm in the UI, so I could not check if it has the issue. Only UIPortalForm and UIPageForm seem to be affected where the UIListPermissionSelector is placed in a UIFormInputSet.
Peter Palaga <ppalaga> made a comment on jira GTNPORTAL-2804 The fix adds the two missing i18n keys using {{\#\{UITabPane.title.UIListPermissionSelector\}}} so it was enough to add them into the file for locale "en". Other locales can resolve the expression into the proper language specific value. The fix also fixes the issue with missing icon. In this case the {{.UITabSelector .FlatTabStyle .UIPermissionSelector24x24Icon}} rule was simply copied and renamed to match the expected class names {{PortalPermissionSelector24x24Icon}} and {{PagePermissionSelector24x24Icon}}.
PR submitted to GateIn 3.5.x branch. https://github.com/gatein/gatein-portal/pull/319
*** Bug 902361 has been marked as a duplicate of this bug. ***
Assigning to Bolek, making sure it goes in GateIn 3.5.2
Fix will be in 3.5.2
Verified on gatein master (3.6.0.MO1-SNAPSHOT).
verified on jpp6.0.cr01
Doesn't require a release note, bug happened between 2 internal releases