Bug 903826

Summary:	Review Request: perl-Net-Domain-TLD - Work with TLD names
Product:	[Fedora] Fedora	Reporter:	Normunds <fedorapkg>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-01 13:56:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	904329

Description Normunds 2013-01-24 21:47:25 UTC

Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Net-Domain-TLD.spec
SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Net-Domain-TLD-1.69-1.fc16.src.rpm
Description: The purpose of this module is to provide user with current list of available top level domain names including new ICANN additions and CC TLDs
Fedora Account System Username: normunds

Comment 1 Normunds 2013-01-24 21:58:23 UTC

Bug 903829, Bug 903826, Bug 903824 are my first Fedora packages, yet more to come. I checked them with both Mock and Koji for all Fedora releases (16, 17, 18, 19, rawhide).

Comment 2 Normunds 2013-01-26 10:20:44 UTC

All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.

Need sponsor.

bug 903824 perl-Convert-Age.spec
bug 903826 perl-Net-Domain-TLD.spec
bug 903829 perl-Time-Interval.spec
bug 904328 perl-Config-ApacheFormat.spec
bug 904329 perl-Data-Validate-Domain.spec
bug 904330 perl-Data-Validate-IP.spec
bug 904331 perl-Shell.spec

Thanks.

Comment 3 Petr Šabata 2013-01-28 12:56:22 UTC

Also taking this one...

Comment 4 Petr Šabata 2013-01-28 13:06:23 UTC

Issues:

Command macros (see #903824).

Missing build-time dependencies:
perl(base), lib/Net/Domain/TLD.pm:3
perl(Carp), lib/Net/Domain/TLD.pm:9
perl(constant), lib/Net/Domain/TLD.pm:12
perl(Exporter), lib/Net/Domain/TLD.pm:3
perl(Storable), lib/Net/Domain/TLD.pm:10

Substite PERL_INSTALL_ROOT with preferred DESTDIR.

Line 43 is not required.

I'd remove the last sentence and the links from the package description.

Comment 5 Normunds 2013-01-28 21:59:55 UTC

Spec file and src package updated.

 * Fixed dependencies.
 * Replaced PERL_INSTALL_ROOT with preferred DESTDIR.
 * Replaced macros with simple commands.
 * Removed useless lines
 * Fixed long description.

New package overwritten in original location.

Comment 6 Petr Šabata 2013-01-29 14:36:12 UTC

You could also drop the %{__perl} macro on the MODULE_COMPAT line.
Anyway, the package looks good and I'll approve it once you get sponsored.

Comment 7 Petr Šabata 2013-01-29 14:43:26 UTC

Sponsored.  Approving.

Comment 8 Normunds 2013-01-31 22:02:23 UTC

Removed macro, re-checked dependencies, removed e-mail from changelog.

New Package SCM Request
=======================
Package Name: perl-Net-Domain-TLD
Short Description: Work with TLD names
Owners: normunds psabata
Branches: f16 f17 f18
InitialCC: perl-sig

Comment 9 Gwyn Ciesla 2013-02-01 13:48:55 UTC

This is already in Fedora:
https://admin.fedoraproject.org/pkgdb/acls/name/perl-Net-Domain-TLD

Comment 10 Petr Šabata 2013-02-01 13:56:58 UTC

(In reply to comment #9)
> This is already in Fedora:
> https://admin.fedoraproject.org/pkgdb/acls/name/perl-Net-Domain-TLD

Indeed, sorry for that.