Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Net-Domain-TLD.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Net-Domain-TLD-1.69-1.fc16.src.rpm Description: The purpose of this module is to provide user with current list of available top level domain names including new ICANN additions and CC TLDs Fedora Account System Username: normunds
Bug 903829, Bug 903826, Bug 903824 are my first Fedora packages, yet more to come. I checked them with both Mock and Koji for all Fedora releases (16, 17, 18, 19, rawhide).
All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems. Need sponsor. bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec Thanks.
Also taking this one...
Issues: Command macros (see #903824). Missing build-time dependencies: perl(base), lib/Net/Domain/TLD.pm:3 perl(Carp), lib/Net/Domain/TLD.pm:9 perl(constant), lib/Net/Domain/TLD.pm:12 perl(Exporter), lib/Net/Domain/TLD.pm:3 perl(Storable), lib/Net/Domain/TLD.pm:10 Substite PERL_INSTALL_ROOT with preferred DESTDIR. Line 43 is not required. I'd remove the last sentence and the links from the package description.
Spec file and src package updated. * Fixed dependencies. * Replaced PERL_INSTALL_ROOT with preferred DESTDIR. * Replaced macros with simple commands. * Removed useless lines * Fixed long description. New package overwritten in original location.
You could also drop the %{__perl} macro on the MODULE_COMPAT line. Anyway, the package looks good and I'll approve it once you get sponsored.
Sponsored. Approving.
Removed macro, re-checked dependencies, removed e-mail from changelog. New Package SCM Request ======================= Package Name: perl-Net-Domain-TLD Short Description: Work with TLD names Owners: normunds psabata Branches: f16 f17 f18 InitialCC: perl-sig
This is already in Fedora: https://admin.fedoraproject.org/pkgdb/acls/name/perl-Net-Domain-TLD
(In reply to comment #9) > This is already in Fedora: > https://admin.fedoraproject.org/pkgdb/acls/name/perl-Net-Domain-TLD Indeed, sorry for that.