Bug 903926

Summary: Project maintainer should be able to define and save validations rules per project/document
Product: [Retired] Zanata Reporter: Alex Eng <aeng>
Component: UsabilityAssignee: Alex Eng <aeng>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: medium Docs Contact:
Priority: unspecified    
Version: developmentCC: sflaniga, zanata-bugs
Target Milestone: ---   
Target Release: 2.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 2.2-SNAPSHOT (20130215-1232) Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-27 03:25:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 846314    

Description Alex Eng 2013-01-25 04:42:09 UTC
Description of problem:
Project maintainer should be able to define and save validations rules per project/document

Comment 1 Sean Flanigan 2013-01-29 02:50:10 UTC
On 2013-01-29 10:19, Alex Eng wrote:
> Question regarding this RFE...

Well, it's your RFE!  ;-)

> 1) Do we persist the validation rules on Project level OR Version
> level (new db table)? And I assume there will be a page for project
> maintainer to manage those rules against the project or version?


Both, inherited.  Similar to custom locale lists.

 
> 2) The second part of the implementation is on persisting rules on
> document level (another db table). It will inherits the rules from
> project or version and apply to each of the documents.
> 
> Who will manage the validation rules against the document? Do we need
> another similar page to manage the rules against each documents?

Where did the description "Project maintainer should be able to
define and save validations rules per project/document" come from?  I'm not convinced it needs to be at the document level.  At least to begin with.
 
> Currently all translators can on/off any of the validation rules, do
> we limit their access on turning on/off those rules set by
> maintainers?

I think the general rules should be:

Project maintainer chooses soft (suggested/recommended) and hard (enforced) rules

Translators may disable suggested rules

Translators may not disable enforced rules.

Translators may enable extra rules.

Comment 3 Alex Eng 2013-02-11 23:14:06 UTC
fix unit test and implement inheritance of validation rules when create new version

https://github.com/zanata/zanata/commit/09c218b246a054d307626a29085b94291619f97d
https://github.com/zanata/zanata/commit/1987a76264be65dee89213a9b32c4c95e3f57e06

Comment 4 Ding-Yi Chen 2013-02-15 07:12:56 UTC
VERIFIED with Zanata version 2.2-SNAPSHOT (20130215-1232)

Comment 5 Sean Flanigan 2013-11-27 03:16:02 UTC
Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 6 Sean Flanigan 2013-11-27 03:17:06 UTC
Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 7 Sean Flanigan 2013-11-27 03:19:19 UTC
Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 8 Sean Flanigan 2013-11-27 03:25:20 UTC
Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 9 Sean Flanigan 2013-11-27 03:34:03 UTC
Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 10 Sean Flanigan 2013-11-27 03:36:14 UTC
Closing VERIFIED bugs for Zanata versions <= 3.1.